Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191113013114.3013-1-james.qian.wang@arm.com>
In-Reply-To: <20191113013114.3013-1-james.qian.wang@arm.com>
From:   Daniel Vetter <daniel@ffwll.ch>
Date:   Wed, 13 Nov 2019 09:05:08 +0100
Message-ID: <CAKMK7uHPcrCdkF7AJ06NzRR+hiR3O4seCCtRUf-wO1Y0NF2g2g@mail.gmail.com>
Subject: Re: [PATCH] drm/komeda: Fix komeda driver build error
To:     "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc:     "airlied@linux.ie" <airlied@linux.ie>,
        "sean@poorly.run" <sean@poorly.run>,
        Mihail Atanassov <Mihail.Atanassov@arm.com>, nd <nd@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 13, 2019 at 2:32 AM james qian wang (Arm Technology China)
<james.qian.wang@arm.com> wrote:
>
> Fix the build errors lead by
>
> 'commit 4039f0293bbd ("drm/komeda: Add option to print WARN- and INFO-level IRQ events")'
>
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Please also re-enable the komde driver (including all options) in all
the defconfigs in drm-rerere. And maybe type some scripts to compile
test before pushing :-)
-Daniel

> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> index 15f52e304c08..d406a4d83352 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -51,12 +51,12 @@
>
>  #define KOMEDA_WARN_EVENTS     KOMEDA_ERR_CSCE
>
> -#define KOMEDA_INFO_EVENTS ({0 \
> +#define KOMEDA_INFO_EVENTS (0 \
>                             | KOMEDA_EVENT_VSYNC \
>                             | KOMEDA_EVENT_FLIP \
>                             | KOMEDA_EVENT_EOW \
>                             | KOMEDA_EVENT_MODE \
> -                           })
> +                           )
>
>  /* malidp device id */
>  enum {
> --
> 2.20.1
>


-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch