Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1570387ybc; Wed, 13 Nov 2019 00:30:48 -0800 (PST) X-Google-Smtp-Source: APXvYqwIS7ZWQHWy9UlZ0Zxuwy3VW7LaxTyCPjTNzbv2cWmsPiOsBNQ61m4qpVgKbFoyHzzxItRc X-Received: by 2002:a17:907:205b:: with SMTP id pg27mr1527221ejb.144.1573633848040; Wed, 13 Nov 2019 00:30:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573633848; cv=none; d=google.com; s=arc-20160816; b=Z62ANkqd9QUCagUs5y5lvmfZUkfMv4PnDSW0w1b88UxZsOUgDwoGzMyXdFGu9JFZcL 4qTkbbBgxKVfZxFnKRMfThaK5JeQQz26HWXoNbmd2ADpAZB5y5+ClgHH2AtQcLx+O7Kz FFSJ3avZ3hNv0nMEy512FHpuKgJR7+pQwypCGrAshFzPw1D0B+lwUbNcatvRgcqdUA5w 4qfG+GBX2UiwpGQoqvSh5wYXiek6qsODCjkTUxCrfB73v0Lb+GUT61oxVPm6BGP7I6U2 28N7leYorQcqN/yMsSd+K3MLVTSFv3ZwWdOMxeWcHF1mqkz/m2QnbooW1KmZLe1iDF5f ppxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HUlJKxSb206fnxwJaIVeyt16K+PMELRcWcNa+iKeQpI=; b=k71A04n9teB8pU5xpc42qRkO4NpYoofP5BeypeKXw3uoDvzbvYBjFUSrFKMYhjvgxY DCfnxTy0vgGjJfC1qV255cRcjA5sE6dhv/5UIUtIIoHqbip88kFGotZbmSt/2Mr6GyjG n6H5nhZDKuxtU/qx3t/R5rbQpE4ehJ8qwN5gCquqq2g2KZFreqWo8cE9wFvzf5MVUsHn 1Nj0ee4SQzUpIMKBbniHSXZSSX/d1OgTr8eR4t1c3XyT7huvWIEeF87lLEn0ueL229IS BOXn9yvhR9/UxJR8iWDQwsQ3EHttb6Rur1vR8b+z9GOyTGnbyY0d5YahwqbjBEEu786L kY3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=RRnBMVhW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=opensource.cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u24si1004491edl.447.2019.11.13.00.30.22; Wed, 13 Nov 2019 00:30:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=RRnBMVhW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=opensource.cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726186AbfKMI13 (ORCPT + 99 others); Wed, 13 Nov 2019 03:27:29 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:47306 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbfKMI13 (ORCPT ); Wed, 13 Nov 2019 03:27:29 -0500 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAD8O2WY011619; Wed, 13 Nov 2019 02:25:19 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=HUlJKxSb206fnxwJaIVeyt16K+PMELRcWcNa+iKeQpI=; b=RRnBMVhWz+xv57PxGF/yWVwxG7Ph6hVsaFMNRZrnsmXLW+TO+0DG28iAQuhmnacdcNZl mvJuyl7RwNaO6l3hqLQQOCPPZ64UDIv1K2L8QmMOUoV07orx5QslPzR9uJTmGToSFVMC LGCTjQOnUPTnCnByXUl+lbYfJRsx8MWJQ2XpZVPDjBKoLrQNu2uF+uEFTLPNBdq+nxnu qidM7yFLJ6QKgsQgB7zmHkp6C546/fZ37fIebQObiS2MIhE9LG3LUiL0plcGd+9dUequ KNjPpwrCCmRI85vK0Ggh92FcKiFuJGrBHMC+0F4pr/hALLRKoRRJGdjjzmt+/CODju2o 0g== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 2w5trnx073-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 13 Nov 2019 02:25:17 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Wed, 13 Nov 2019 08:25:15 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1591.10 via Frontend Transport; Wed, 13 Nov 2019 08:25:15 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 3D0302A1; Wed, 13 Nov 2019 08:25:15 +0000 (UTC) Date: Wed, 13 Nov 2019 08:25:15 +0000 From: Charles Keepax To: Michael Walle CC: , , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Subject: Re: [PATCH] ASoC: wm8904: fix regcache handling Message-ID: <20191113082515.GE10439@ediswmail.ad.cirrus.com> References: <20191112223629.21867-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20191112223629.21867-1-michael@walle.cc> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 clxscore=1015 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 mlxscore=0 mlxlogscore=614 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911130077 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 12, 2019 at 11:36:29PM +0100, Michael Walle wrote: > The current code assumes that the power is turned off in > SND_SOC_BIAS_OFF. If there are no actual regulator the codec isn't > turned off and the registers are not reset to their default values but > the regcache is still marked as dirty. Thus a value might not be written > to the hardware if it is set to the default value. Do a software reset > before turning off the power to make sure the registers are always reset > to their default states. > > Signed-off-by: Michael Walle > --- Acked-by: Charles Keepax Thanks, Charles