From: Junio C Hamano <junkio@cox.net>
To: Arjan van de Ven <arjan@infradead.org>
Subject: Re: [patch 00/62] sem2mutex: -V1
References: <20060113124402.GA7351@elte.hu>
	<200601131400.00279.baldrick@free.fr> <20060113134412.GA20339@elte.hu>
	<200601131925.34971.ioe-lkml@rameria.de>
	<20060113195658.GA3780@elte.hu> <43C815E3.10005@gmail.com>
	<1137187555.2975.13.camel@laptopd505.fenrus.org>
cc: Ingo Molnar <mingo@elte.hu>, Ingo Oeser <ioe-lkml@rameria.de>,
       linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
       Linus Torvalds <torvalds@osdl.org>,
       Jes Sorensen <jes@trained-monkey.org>, Greg KH <greg@kroah.com>,
       chaosite@gmail.com
Date: Fri, 13 Jan 2006 14:09:52 -0800
In-Reply-To: <1137187555.2975.13.camel@laptopd505.fenrus.org> (Arjan van de
	Ven's message of "Fri, 13 Jan 2006 22:25:54 +0100")
Message-ID: <7v64on3hlb.fsf@assigned-by-dhcp.cox.net>
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1461
Lines: 41

Arjan van de Ven <arjan@infradead.org> writes:

> On Fri, 2006-01-13 at 23:04 +0200, Matan Peled wrote:
>> Ingo Molnar wrote:
>> > Ingo Oeser wrote:
>> >> Could we get for each of these and a mutex:
>> >>
>> >>  - description 
>> >>  - common use case
>> >>  - small argument why this and nothing else should be used there
>> > 
>> > like ... Documentation/mutex-design.txt?
>> 
>> I think what he wanted was an explanation for the change of each and every 
>> sem... Which is kind of hard with automated tools.
> `
> it's also HIGHLY repetitive.
> 1) The process is : Look at semaphore and it's uses.
> 2) Decide it's a mutex
> 3) Run script to convert to mutex
> 4) Run script to validate the conversion
> 5) build+boot test
>
> I can't think of a way to describe that uniquely different for each
> one ;0

I do not read Ingo Oeser's request as such, but if somebody does
1) and 2), ideally, the knowledge obtained during that process,
i.e. what is being protected and what the invariants are, and
the reasoning why it is a mutex, could serve as a good
documentation for people who want to further work on that code
being converted to use mutex.

However, I think demanding Ingo (Molnar) to do all that is
unfair.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/