Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1636011ybc; Wed, 13 Nov 2019 01:51:58 -0800 (PST) X-Google-Smtp-Source: APXvYqxQyutlr0qolFkDw7bo72K+CtTkvlM72EBIHkP7XrYonOfOPlmI1JJ5ezJOQacU1h2eah+K X-Received: by 2002:aa7:c453:: with SMTP id n19mr2572787edr.103.1573638718105; Wed, 13 Nov 2019 01:51:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573638718; cv=none; d=google.com; s=arc-20160816; b=RUsoSiyO8v0yR9xm7ZgdUXMcUA4R4BEJQTFPe0A+uOumGxHju4CeAIn63S/59aq1W+ 0uE0OHc+zHXTwE8qgU/nR6J808UGDyR9c/XEKagfD4/ROHTvM7n/hT9xFY1MnlEqMBSG fipue6b8wuWOSO67YUXeo1FE17uMeHfwjHaiQISv12EsyfomlBPfre6tSY5GRejNouhe of728BmX7zCfvkyf6gusS7fY0S1+y8YI6xfejM/LSwRcB6KEuCcdpErLC4CqFqiZnbEH Ep213ykMMrdy5YC1MsrkrPQka0ZhG5kZR6euCawDzKP4PYl1/aW3txBwJcq6JVNvGlWG FxBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=iJ47GM6GLrLMBNqOH44n0dI1q9xzI9tGhJMYN+0NYFw=; b=KXZzM1JaodHPuQFg40Udf2eSVIWMnh97AhDZY3M/rTvBR89R3XicAJKFA/TkChUQPj Md8j3tVS5qSNYb0BcCViiuwRB+HKrzcBZD4mQH32jTmRkiUi8Uu3c3dfKIovvy1ltic3 aFvgA61U2hU/vyHPidjOWfHiD0ed/VFFLPxNkayGIiTvnkn8eqOvaQf1gkjDZecHY/oe oLQD0qLoXwO3fRvKiseEi+N6s6noCdpG9GOfI0Q4GNjRjcY9QhVusLOCx5n21y2QM85x 5Muy4Roj1PevdfQcbs44afPOMD/FQ4gmnrq4yujHZSsfgCYYS8Z02mQRjChOr3eiQz15 IUig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n15si757938ejj.68.2019.11.13.01.51.33; Wed, 13 Nov 2019 01:51:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727672AbfKMJr7 (ORCPT + 99 others); Wed, 13 Nov 2019 04:47:59 -0500 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:57618 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727445AbfKMJr6 (ORCPT ); Wed, 13 Nov 2019 04:47:58 -0500 Received: from [109.168.11.45] (port=55110 helo=[192.168.101.73]) by hostingweb31.netsons.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1iUpFj-001uIA-Ox; Wed, 13 Nov 2019 10:47:55 +0100 Subject: Re: [PATCH v3 3/3] i2c: smbus: switch from loops to memcpy To: Dmitry Torokhov , Wolfram Sang Cc: linux-iio@vger.kernel.orgi, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191112203132.163306-1-dmitry.torokhov@gmail.com> <20191112203132.163306-4-dmitry.torokhov@gmail.com> From: Luca Ceresoli Message-ID: <320567eb-00f5-2228-c507-317131b4af74@lucaceresoli.net> Date: Wed, 13 Nov 2019 10:47:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191112203132.163306-4-dmitry.torokhov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On 12/11/19 21:31, Dmitry Torokhov wrote: > When copying memory from one buffer to another, instead of open-coding > loops with byte-by-byte copies let's use memcpy() which might be a bit > faster and makes intent more clear. Good idea! Reviewed-by: Luca Ceresoli -- Luca