Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1646980ybc; Wed, 13 Nov 2019 02:04:34 -0800 (PST) X-Google-Smtp-Source: APXvYqzuDtqOnz//lOG0Pu8U03s+RoJlnJKi2JEGan4E4moNupFvV4fMIgN/ZsA8hnHBUtsguhJY X-Received: by 2002:a17:906:c2d6:: with SMTP id ch22mr1909527ejb.262.1573639474219; Wed, 13 Nov 2019 02:04:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573639474; cv=none; d=google.com; s=arc-20160816; b=0oFxMLtFt9YBEtZ8p/2/kPSK89BwqrL0t8oQLLzfzD34IPUhF837Fl23PzlU8UUUxY 4zC/pwz6m8fCpz1HRb3fT+fLbWHUcMPgkN+lTXsikr0QqqFvdQYJD9smjRMne7f4ha8W C2KefdgDFWlJ66QY6frb6LDzbiFepCrQIBDZf5urSycNxFDa8JUqmlAwC0GooQRgmALt McdPyUdW2QuAkjARSbBiyaVyPBsx675WnlDZfqFrMW8+Yk4uq06p1ohStKR7YyC5AzkL sVgWC7O5WTLxEVYr0NOYjd32D2Cn/rIpggMpGmMVBeEcOOOxRLXTefkMD5KRMIx+or5S T1Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=8npyElVmkqIYUEONGW6BaLT2vSlAx7G5q4l2vd7Fvls=; b=RkgY5kH87tQg2Anm4ZmCy4CMDysHD+d6caZPVO1pLeoclLSyerAg5Zy0fqdP8aRsDB SfY5S+sj84egjUjdRd55kraLPV5NITnd9G+MUAk/4qD27aPiMp7qJHCrUFxwH7paMcZc oPsohFLWBqrRkK5tSYwQIN0amjqjsxF5cMhiq3fZRRWbqPCUMqZ72m4NwG01Ml+8Vf05 CtWFiryWjFt0+XCa91+MCYHxE6XwhZEVNmqLEOTEX2KCZcA0NyDi3/kfntQCILpThAWG Sl/IJULnXxhM3k+N3AW9WNNGerh07kyUZwqKnyhNzAreVquRP9feAuqEGQWFDDJ+vxfN nMuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e25si1090497ede.335.2019.11.13.02.04.09; Wed, 13 Nov 2019 02:04:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727378AbfKMKCh (ORCPT + 99 others); Wed, 13 Nov 2019 05:02:37 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:49543 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbfKMKCg (ORCPT ); Wed, 13 Nov 2019 05:02:36 -0500 Received: from mail-qv1-f47.google.com ([209.85.219.47]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MnJQq-1i5QHX0JUK-00jKlY; Wed, 13 Nov 2019 11:02:35 +0100 Received: by mail-qv1-f47.google.com with SMTP id g18so548363qvp.8; Wed, 13 Nov 2019 02:02:34 -0800 (PST) X-Gm-Message-State: APjAAAX7yCrHijEkYTtxKki5faVfaT/9hMAymSqjcuIPHR64yKFmaJRH IpWuhPwlb02Hp0Vjk5cyvF86Qz729PGdm0dEZQM= X-Received: by 2002:a05:6214:2c2:: with SMTP id g2mr1912289qvu.210.1573639353874; Wed, 13 Nov 2019 02:02:33 -0800 (PST) MIME-Version: 1.0 References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-2-arnd@arndb.de> <20191112210915.GD5130@uranus> In-Reply-To: <20191112210915.GD5130@uranus> From: Arnd Bergmann Date: Wed, 13 Nov 2019 11:02:12 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/23] y2038: rusage: use __kernel_old_timeval To: Cyrill Gorcunov Cc: y2038 Mailman List , Richard Henderson , Ivan Kokshaysky , Matt Turner , "linux-kernel@vger.kernel.org" , Deepa Dinamani , Thomas Gleixner , Will Deacon , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Catalin Marinas , Dave Hansen , alpha Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:YIPfmykULQ1zK4fCM0+v3SRSEDJy816mv2/j4VwFYT5i34gtSMd QL4HmsWsze7QHJoImBkX5KB7kfJq+PtHLTvM1twH/jcq0NbUxIYfUzFeW9qSPEMTXggGIeu 0IGmj3YVOAG3pVHWz4Ps4+zp4iek85QLXTAfKjuPTEQkankeP5MXMkC7D3JRZYIuX7rop7Z N5XvuOL9HU5Gn4ovyV9sw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6TymcqjPZJY=:xKPDKgq+K9+YU+TaJA0rXF CNmz6Rc+4HzXN8jO3B9eQa/dtWoX8SvjrqNfLdyybDStmElrOOBG8dEe3KTAcFmbZxIctG6/u vaRFnmni5NbHjhUsUoC1p0pVNt222XcGY6EamNFesetUT9jHKacmd5zm7Kb4UDUs5g5YURFVW yXI1VP9/dlt0Ojugunnph8LDp+0jQtwDm82BUXjuKFts1+kgzwwaCDZdMAW2FI7ZgwKS/f9uO menFyYrp177LVpbgg5+i9OEtJoOdSES1vcBS/+ej1lMg01prJ+VwmIbT6Nz7PcaOCkHdsLnW/ FwrABKkF1wkUOKA9qwm3d8eqfgmT12zaag6Veq4jJ4XQk75e+I/WXPQrcfe79P1+ZKeVZpHaZ hxTI1HccCsALBnzm6HLutwd/8XGgJ1pbbQqycff+ZSebSWRENCJMRtRQxY9q/5uPpWVhTiju+ xzjQeY59qYB57E5kzfWl0eo+mVGLWCNtwBW0QRA6IYCz4qU0fPYFGeBV3YWjkRIwwsWLJUqkH yp/FTnjBiRF0WYNFG6w/4yz8XOAm4M5qPP9GuYa2ABQ5UiDvyL29zbnDIWJMSxKs1ruwg7Z2y 3v+vKrCwbQo5qUjbLlzEmg+g9aAkH+215khbyjEfqqeTnR/ASIdgZhXirK+d6g+yZ+kMp+xwv pPwHom34YqKf8q16l6Zyfe0iWJ1lHOVWvciFrlgtQ0+nk/X2uf40N/vU+dWAkXyEUrMrLTPqJ zZf3fP0Uky4R35jBs0K9uXzM7spTJRkIL6xIRxdngfHNOY0NZUOmbkdyqiVa/jKF3Si3fp0BZ EKYf1waxLnfM2if9SLJAPwFGIEud+jslibyyQum3tnxdnhcjfQsB63Z0abHiQGJp9oHugMDtp sqISJpt2u+44RViAu/RQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 12, 2019 at 10:09 PM Cyrill Gorcunov wrote: > > On Fri, Nov 08, 2019 at 10:12:10PM +0100, Arnd Bergmann wrote: > > --- > > Question: should we also rename 'struct rusage' into 'struct __kernel_rusage' > > here, to make them completely unambiguous? > > The patch looks ok to me. I must confess I looked into rusage long ago > so __kernel_timespec type used in uapi made me nervious at first, > but then i found that we've this type defined in time_types.h uapi > so userspace should be safe. I also like the idea of __kernel_rusage > but definitely on top of the series. There are clearly too many time types at the moment, but I'm in the process of throwing out the ones we no longer need now. I do have a number patches implementing other variants for the syscall, and I suppose that if we end up adding __kernel_rusage, that would have to go with a set of syscalls using 64-bit seconds/nanoseconds rather than the old 32/64 microseconds. I don't know what other changes remain that anyone would want from sys_waitid() now that it does support pidfd. If there is still a need for a new waitid() replacement, that should take that new __kernel_rusage I think, but until then I hope we are fine with today's getrusage+waitid based on the current struct rusage. BSD has wait6() to return separate rusage structures for 'self' and 'children', but I could not find any application (using the freebsd sources and debian code search) that actually uses that information, so there might not be any demand for that. > Reviewed-by: Cyrill Gorcunov Thanks, Arnd