Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1652269ybc; Wed, 13 Nov 2019 02:09:55 -0800 (PST) X-Google-Smtp-Source: APXvYqzEo35KHqtWEkn14QGhKDDxuurtKDyzA6WgQ6Uo/QJuX6+zaJ8yQ37Ma+ZU+DLIrFIGl6re X-Received: by 2002:a05:6402:12ca:: with SMTP id k10mr2491815edx.255.1573639795642; Wed, 13 Nov 2019 02:09:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573639795; cv=none; d=google.com; s=arc-20160816; b=FWV2YrBMAuh6Fn8vauERyi39Is+QIZzpNzDDrNKg33RJsFvAqMKySjDm6IqeZTions UGjLjSmXmDluLHkrgG0aiZ4pziy3qXWUtpm0Q7vDCHCmRSwXry0o8kLU9/5wEHlVRC4K UhK2R53aWLF4Z1mBjxelilkfhGg6bFCgEPD0K7yxHviVpCS3Gb3IFp+iDraLiiSTTOmB 2wYmapOoQxws/7+eq4jIaFqeuq6OZb2Oqc3iNLZj0gf+GTmw8OGHa+Gm0SqtuwXPDhuz 24KKpWFO+hNAY+JXAZj8obUcwtd1Fz7Qngf8MBRKN7PY07so5mrhhgl+R2kENYBPDnJs 4X8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :robot-unsubscribe:robot-id:message-id:mime-version:references :in-reply-to:cc:subject:to:reply-to:from:date; bh=fSzxooTX8sGed8IEEjzUSZ6Eje2gUI1wl7WU8VUnSjs=; b=Z9G8AI0xLQnLyIpANScH7Ep5xRVE/I65CcWHGmFu9GMHiRsoAnLKLm3PxCOjxrAUen Lba8TPTIfIHieAp0y/jbSWNg6+rgZAvqD5F4PoLxiQEth+ArlYCz71CyPRul4e3VMi8z Jwowh8ttoW7TELAajFEh8Fq7EihawtBeudNrspSbQ9kH1rnWLW6gg8cWxI2soSRoI4as gMT1XZ9VTsITQH9RD+dz8ktYL7SSrfUgwpHeEe61U911pfS9DXKC3OM2FWbdbS4YiP1T kx7D2tjzk2CS7stio12x1jvVGrUcj9UdKEqcGp2ERt12dE4eRVMV/mVDvzY+zIyfqc2t DLZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e25si1090497ede.335.2019.11.13.02.09.31; Wed, 13 Nov 2019 02:09:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727487AbfKMKGq (ORCPT + 99 others); Wed, 13 Nov 2019 05:06:46 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:37163 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbfKMKGl (ORCPT ); Wed, 13 Nov 2019 05:06:41 -0500 Received: from [5.158.153.53] (helo=tip-bot2.lab.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iUpXf-0000HO-Nu; Wed, 13 Nov 2019 11:06:27 +0100 Received: from [127.0.1.1] (localhost [IPv6:::1]) by tip-bot2.lab.linutronix.de (Postfix) with ESMTP id 59E9A1C0092; Wed, 13 Nov 2019 11:06:27 +0100 (CET) Date: Wed, 13 Nov 2019 10:06:26 -0000 From: "tip-bot2 for Alexander Shishkin" Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: perf/urgent] perf/core: Reattach a misplaced comment Cc: Alexander Shishkin , "Peter Zijlstra (Intel)" , Arnaldo Carvalho de Melo , David Ahern , Jiri Olsa , Linus Torvalds , Mark Rutland , Namhyung Kim , Stephane Eranian , Thomas Gleixner , Vince Weaver , Ingo Molnar , Borislav Petkov , linux-kernel@vger.kernel.org In-Reply-To: <20191030134731.5437-2-alexander.shishkin@linux.intel.com> References: <20191030134731.5437-2-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Message-ID: <157363958684.29376.5993067726594499698.tip-bot2@tip-bot2> X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the perf/urgent branch of tip: Commit-ID: f25d8ba9e1b204b90fbf55970ea6e68955006068 Gitweb: https://git.kernel.org/tip/f25d8ba9e1b204b90fbf55970ea6e68955006068 Author: Alexander Shishkin AuthorDate: Wed, 30 Oct 2019 15:47:30 +02:00 Committer: Ingo Molnar CommitterDate: Wed, 13 Nov 2019 08:16:41 +01:00 perf/core: Reattach a misplaced comment A comment is in a wrong place in perf_event_create_kernel_counter(). Fix that. Signed-off-by: Alexander Shishkin Signed-off-by: Peter Zijlstra (Intel) Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Jiri Olsa Cc: Linus Torvalds Cc: Mark Rutland Cc: Namhyung Kim Cc: Stephane Eranian Cc: Thomas Gleixner Cc: Vince Weaver Link: https://lkml.kernel.org/r/20191030134731.5437-2-alexander.shishkin@linux.intel.com Signed-off-by: Ingo Molnar --- kernel/events/core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index b752bd3..e18d8d3 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -11331,10 +11331,6 @@ perf_event_create_kernel_counter(struct perf_event_attr *attr, int cpu, struct perf_event *event; int err; - /* - * Get the target context (task or percpu): - */ - event = perf_event_alloc(attr, cpu, task, NULL, NULL, overflow_handler, context, -1); if (IS_ERR(event)) { @@ -11345,6 +11341,9 @@ perf_event_create_kernel_counter(struct perf_event_attr *attr, int cpu, /* Mark owner so we could distinguish it from user events. */ event->owner = TASK_TOMBSTONE; + /* + * Get the target context (task or percpu): + */ ctx = find_get_context(event->pmu, task, event); if (IS_ERR(ctx)) { err = PTR_ERR(ctx);