Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1686754ybc; Wed, 13 Nov 2019 02:47:50 -0800 (PST) X-Google-Smtp-Source: APXvYqw/AKRPxsPpgSLD4ZVly1FKOokQiFDP+tRhiu9+lIczgB2wY/LhZXBaHh7EwG/1K9ZDB3++ X-Received: by 2002:a50:ef16:: with SMTP id m22mr2703041eds.154.1573642069957; Wed, 13 Nov 2019 02:47:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573642069; cv=none; d=google.com; s=arc-20160816; b=wqeKkG19CZlqYGducyoVli5ZYJ8C71V6RpjJbybVb1QKysmDwFD16U28t0xIcgJl9g RnUg6Dp2notAGDr6s78jh/CLLk2c7GXlBbHo+H6kZu5WR0/TeJMb3x1kuzLJABsy7rB1 GzLbozrh6rbtI0avXCwzcNcFAOmmU/gP5uJudfWNPAR1RC7zRw7bklN4aLDt/wNqL0MC U9FiT4jWeKg6GrKHWQagP6nz4p4OcHkNHRHFqBMA+xumYfJYK1Rhyg69yPuT1NFsedbL AJK2MfK1RUvQg40doOdA49EiDQoKmFNNqF3bPhPl6iD/vp1rgVWg0MHWgwPJAdUG1f+h WDeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=dpmNX2WblROiyKPXh/t6fsqJbQz/YRPcS+0W6PE5I/s=; b=hMoS5hZ5PnELsDptANnGZ3HcYDXQ9btB/miaLNf3EzFIbRnnRZALluaKTo1cNIRQm/ 3VXW1bv3xuz3Sy9s2IWL/UsP1eHmPiWWQ52c2tDQyFnJCuobMUuNYbNCXhWt60lal2c6 nrLAMCgJ0ZE6PkNad7LdEPcd+sbiIQ18k8RxoP49t9764RqKIYkB/l5UmOB1sJK/POA/ GpbqgVWRCGj6I6DnWBtM2txYu453sLcvPHh8y+yex11bvzxHEG7+UmcQZuyE+DpbO240 xTxpVgzsCTGA8rm2cYpEiEfjMvjDGd7U/fUHdY/Is1JDqbZA2SCiWCaAfO9G3bS5hKnr tFww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o57si1045693edc.240.2019.11.13.02.47.25; Wed, 13 Nov 2019 02:47:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727500AbfKMKp6 (ORCPT + 99 others); Wed, 13 Nov 2019 05:45:58 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:2093 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726138AbfKMKp6 (ORCPT ); Wed, 13 Nov 2019 05:45:58 -0500 Received: from lhreml702-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id E888C4C444F589C77A84; Wed, 13 Nov 2019 10:45:56 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by lhreml702-cah.china.huawei.com (10.201.108.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 13 Nov 2019 10:45:56 +0000 Received: from [127.0.0.1] (10.202.226.46) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 13 Nov 2019 10:45:55 +0000 Subject: Re: [QUESTION]perf stat: comment of miss ratio To: Andi Kleen , "liuqi (BA)" CC: "linux-kernel@vger.kernel.org" , "Peter Zijlstra" , Ingo Molnar , "Arnaldo Carvalho de Melo" , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Jin Yao , Ravi Bangoria , Davidlohr Bueso , Zhangshaokun , huangdaode , linyunsheng References: <20191109024754.GA573472@tassilo.jf.intel.com> From: John Garry Message-ID: <71f30f49-d8b4-abff-9f75-674dcbb7fad0@huawei.com> Date: Wed, 13 Nov 2019 10:45:54 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191109024754.GA573472@tassilo.jf.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.46] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2019 02:47, Andi Kleen wrote: >> Relevant code is checked to make sure that the ratio is calculated by >> >> L1-dcache-load-misses/L1-dcache-loads, data "7.58%=30249/399189*100%" also >> >> proves this conclusion. >> >> So, I'm not sure why we use "of all L1-dcache hits" here to describe miss >> ratio, > > Yes you're right it should be "of all L1-dcache accesses" > > Please send a patch to fix the string and also check if this isn't wrong with some other > ratio too. > " 399,189 L1-dcache-loads # 246.396 M/sec 30,249 L1-dcache-load-misses # 7.58% of all L1-dcache hits (18.04%)" If accesses and loads are equivalent, could we use consistent terminology? Thanks, John