Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/5] iio: ping: add parallax ping sensors
To:     Jonathan Cameron <jic23@kernel.org>,
        Andreas Klinger <ak@it-klinger.de>
Cc:     robh+dt@kernel.org, mark.rutland@arm.com, mripard@kernel.org,
        shawnguo@kernel.org, heiko@sntech.de, icenowy@aosc.io,
        laurent.pinchart@ideasonboard.com, knaack.h@gmx.de,
        lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
        christophe.jaillet@wanadoo.fr, tglx@linutronix.de,
        mchehab+samsung@kernel.org, davem@davemloft.net,
        paulmck@linux.ibm.com, devicetree@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20191107130045.rt3ix2atyjd3gekr@arbad>
 <20191110170650.00527b8b@archlinux>
From:   =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= <michal.vokac@ysoft.com>
Message-ID: <196ba1f0-9d9f-9f46-c86e-2c41a7835c59@ysoft.com>
Date:   Wed, 13 Nov 2019 12:09:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191110170650.00527b8b@archlinux>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10. 11. 19 18:06, Jonathan Cameron wrote:
> On Thu, 7 Nov 2019 14:00:47 +0100
> Andreas Klinger <ak@it-klinger.de> wrote:
  
[snip]

>> + *
>> + *          +---+            +------------------------+
>> + * GPIO     |   |            |                        |
>> + * ping:  --+   +------------+                        +----------------
>> + *          ^   ^            ^                        ^
>> + *          |<->|            interrupt                interrupt
>> + *         udelay(5)         (ts_rising)              (ts_falling)
>> + *                           |<---------------------->|
>> + *                           .  pulse time measured
>> + *                           .  --> one round trip of ultra sonic waves
>> + *                           .                        .
>> + * ultra           +-+ +-+ +-+                        .
>> + * sonic           | | | | | |                        .
>> + * burst: ---------+ +-+ +-+ +-----------------------------------------
>> + *                                                    .
>> + * ultra                                    +-+ +-+ +-+
>> + * sonic                                    | | | | | |
>> + * echo:  ----------------------------------+ +-+ +-+ +----------------
> 
> Nice diagram ;)

Using the '+' characters at the edges and '-' characters for levels makes it
not easily readable in some cases. Especially for the short subsequent bursts.
What about this?

      * GPIO      ___              ________________________
      * ping:  __/   \____________/                        \_________________
      *          ^   ^            ^                        ^
      *          |<->|            interrupt                interrupt
      *         udelay(5)         (ts_rising)              (ts_falling)
      *                           |<---------------------->|
      *                           .  pulse time measured
      *                           .  --> one round trip of ultra sonic waves
      *                           .                        .
      * ultra                     .                        .
      * sonic            _   _   _.                        .
      * burst:  ________/ \_/ \_/ \_________________________________________
      *                                                    .
      * ultra                                              .
      * sonic                                     _   _   _.
      * echo:   _________________________________/ \_/ \_/ \_________________
      */

Michal