Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191113013529.GA64000@TonyMac-Alibaba>
In-Reply-To: <20191113013529.GA64000@TonyMac-Alibaba>
From:   Ilya Dryomov <idryomov@gmail.com>
Date:   Wed, 13 Nov 2019 12:21:10 +0100
Message-ID: <CAOi1vP98n4coOhc79Q+t63sCGvLmpXCwEYf8yuME+ST2K1HDsw@mail.gmail.com>
Subject: Re: 'current_state' is uninitialized in rbd_object_map_update_finish()
To:     Tony Lu <tonylu@linux.alibaba.com>
Cc:     linux-block <linux-block@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 13, 2019 at 2:35 AM Tony Lu <tonylu@linux.alibaba.com> wrote:
>
> Hello,
>
> There is a warning during compiling driver rbd for uninitialized
> 'current state' in rbd_object_map_update_finish():
>
> drivers/block/rbd.c: In function 'rbd_object_map_callback':
> drivers/block/rbd.c:2122:21: warning: =E2=80=98current_state=E2=80=99 may=
 be used uninitialized in this function [-Wmaybe-uninitialized]
>       (current_state =3D=3D OBJECT_EXISTS && state =3D=3D OBJECT_EXISTS_C=
LEAN))
>
> drivers/block/rbd.c:2090:23: note: =E2=80=98current_state=E2=80=99 was de=
clared here
>   u8 state, new_state, current_state;
>                        ^~~~~~~~~~~~~

Hi Tony,

It looks like this warning was also reported by kbuild, on gcc 6.3 and
7.4.  It's bogus, I'll send a patch to silence it.

Thanks,

                Ilya