Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>, "sboyd@kernel.org" <sboyd@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
CC:     "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        Abel Vesa <abel.vesa@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alice Guo <alice.guo@nxp.com>
Subject: Re: [PATCH] clk: imx: pll14xx: introduce imx_clk_hw_pll14xx_flags
Thread-Topic: [PATCH] clk: imx: pll14xx: introduce imx_clk_hw_pll14xx_flags
Thread-Index: AQHVmfO4UT5wBnIiNkiEwV6EPli0Lg==
Date:   Wed, 13 Nov 2019 12:16:32 +0000
Message-ID: <VI1PR04MB7023CD16303E0CB6F524313DEE760@VI1PR04MB7023.eurprd04.prod.outlook.com>
References: <1573629896-23954-1-git-send-email-peng.fan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ab9a7a5a-2e50-468e-aa13-08d768335263
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2019 12:16:32.9465
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LLGuyh5fPOZun7mUCBgcMlQpvsyUdvJ02T3RvhWCCWoJxaYY+Ai2j7eeOT3EF2FRafLeV5/XxLOUdbTscivmgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5280
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13.11.2019 09:26, Peng Fan wrote:=0A=
> From: Peng Fan <peng.fan@nxp.com>=0A=
> =0A=
> Introduce imx_clk_hw_pll14xx_flags, then no need to add new=0A=
> imx_pll14xx_clk variable for new flags.=0A=
> =0A=
> Since the original imx_pll14xx_clk flags is not used, so drop it.=0A=
> =0A=
> Signed-off-by: Peng Fan <peng.fan@nxp.com>=0A=
=0A=
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>=0A=
=0A=
Most other imx clock wrappers take flags as an argument so it's nice to =0A=
be consistent.=0A=
=0A=
> V1:=0A=
>   Based on https://patchwork.kernel.org/patch/11217889/=0A=
=0A=
In general if you sent patches on top of patches it makes sense to =0A=
resend as a series. That clk_hw series is not in yet.=0A=
=0A=
>   drivers/clk/imx/clk-pll14xx.c | 12 +++++++++++-=0A=
>   drivers/clk/imx/clk.h         |  7 ++++++-=0A=
>   2 files changed, 17 insertions(+), 2 deletions(-)=0A=
> =0A=
> diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.=
c=0A=
> index 2bbcfbf8081a..a8af949f0848 100644=0A=
> --- a/drivers/clk/imx/clk-pll14xx.c=0A=
> +++ b/drivers/clk/imx/clk-pll14xx.c=0A=
> @@ -379,6 +379,16 @@ struct clk_hw *imx_clk_hw_pll14xx(const char *name, =
const char *parent_name,=0A=
>   				  void __iomem *base,=0A=
>   				  const struct imx_pll14xx_clk *pll_clk)=0A=
>   {=0A=
> +=0A=
> +	return imx_clk_hw_pll14xx_flags(name, parent_name, base, pll_clk, 0);=
=0A=
> +}=0A=
> +=0A=
> +struct clk_hw *imx_clk_hw_pll14xx_flags(const char *name,=0A=
> +					const char *parent_name,=0A=
> +					void __iomem *base,=0A=
> +					const struct imx_pll14xx_clk *pll_clk,=0A=
> +					unsigned long flags)=0A=
> +{=0A=
>   	struct clk_pll14xx *pll;=0A=
>   	struct clk_hw *hw;=0A=
>   	struct clk_init_data init;=0A=
> @@ -390,7 +400,7 @@ struct clk_hw *imx_clk_hw_pll14xx(const char *name, c=
onst char *parent_name,=0A=
>   		return ERR_PTR(-ENOMEM);=0A=
>   =0A=
>   	init.name =3D name;=0A=
> -	init.flags =3D pll_clk->flags;=0A=
> +	init.flags =3D flags;=0A=
>   	init.parent_names =3D &parent_name;=0A=
>   	init.num_parents =3D 1;=0A=
>   =0A=
> diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h=0A=
> index cd92d9fdccf4..c2851a82b4fd 100644=0A=
> --- a/drivers/clk/imx/clk.h=0A=
> +++ b/drivers/clk/imx/clk.h=0A=
> @@ -48,7 +48,6 @@ struct imx_pll14xx_clk {=0A=
>   	enum imx_pll14xx_type type;=0A=
>   	const struct imx_pll14xx_rate_table *rate_table;=0A=
>   	int rate_count;=0A=
> -	int flags;=0A=
>   };=0A=
>   =0A=
>   extern struct imx_pll14xx_clk imx_1416x_pll;=0A=
> @@ -105,6 +104,12 @@ struct clk_hw *imx_clk_hw_pll14xx(const char *name, =
const char *parent_name,=0A=
>   				  void __iomem *base,=0A=
>   				  const struct imx_pll14xx_clk *pll_clk);=0A=
>   =0A=
> +struct clk_hw *imx_clk_hw_pll14xx_flags(const char *name,=0A=
> +					const char *parent_name,=0A=
> +					void __iomem *base,=0A=
> +					const struct imx_pll14xx_clk *pll_clk,=0A=
> +					unsigned long flags);=0A=
> +=0A=
>   struct clk *imx_clk_pllv1(enum imx_pllv1_type type, const char *name,=
=0A=
>   		const char *parent, void __iomem *base);=0A=