Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4.19 097/125] perf/x86/uncore: Fix event group support
To:     Pavel Machek <pavel@denx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Vince Weaver <vincent.weaver@maine.edu>,
        linux-drivers-review@eclists.intel.com,
        linux-perf@eclists.intel.com, Ingo Molnar <mingo@kernel.org>,
        Sasha Levin <sashal@kernel.org>
References: <20191111181438.945353076@linuxfoundation.org>
 <20191111181452.768177907@linuxfoundation.org> <20191113103531.GB32553@amd>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
Message-ID: <296fc0ff-0d27-872b-0374-066019127813@linux.intel.com>
Date:   Wed, 13 Nov 2019 08:04:13 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20191113103531.GB32553@amd>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/13/2019 5:35 AM, Pavel Machek wrote:
> Hi!
> 
>>   	return ret;
>>   }
>>   
>> +static void uncore_pmu_enable(struct pmu *pmu)
>> +{
>> +	struct intel_uncore_pmu *uncore_pmu;
>> +	struct intel_uncore_box *box;
>> +
>> +	uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
>> +	if (!uncore_pmu)
>> +		return;
> 
> AFAICT this test can never trigger.
> 
>> +static void uncore_pmu_disable(struct pmu *pmu)
>> +{
>> +	struct intel_uncore_pmu *uncore_pmu;
>> +	struct intel_uncore_box *box;
>> +
>> +	uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
>> +	if (!uncore_pmu)
>> +		return;
> 
> And neither can this one.

I will submit a patch to fix it.

Thanks,
Kan