Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1939325ybc; Wed, 13 Nov 2019 06:41:19 -0800 (PST) X-Google-Smtp-Source: APXvYqy8c41vtFKde6Wmm1OCmQcXgK6io2XOH0dsVWBSLtj/5wXBRrGGAo1hdOrTtW03CTCgabj9 X-Received: by 2002:a17:907:426e:: with SMTP id nx22mr2961710ejb.139.1573656079121; Wed, 13 Nov 2019 06:41:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573656079; cv=none; d=google.com; s=arc-20160816; b=Yo8iMc9MTVrJCM4j8YOrddW/a7dHL/uE7IWRYWORnYxT9EM5un0lxurxJJqGisrcEu lYtrA6dFbiPury9n/w7qNrKuu8nkUFY48yBUwS9qEjWxjv68IVKkung9CTBvGS0mR/Qe WuJluNKzAK2L8BsKgL8mgWlVzzQogXd/lmH0VztWl+G2ADtiQLSeaILLAkOHQDtFG6mM ZOImtrYu7lP5mtrzVMNjqMbCoeQcZ/fe/j8Reow8yz71KTi54uC3/S7CTSoEfMlgUUCH ENV/iPhrUeU7ORUiRL3hw47oOKDokc+euGczJeo0/sE3pP3vRzrtg5ybN+b1zbzrY2Ad u78A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:user-agent :in-reply-to:mime-version:references:message-id:subject:cc:to:from :date:dkim-signature; bh=bSHrFQsbaC1yAitK7Law8cbj6Z2ZKZzmHqlB5M3qljE=; b=Aa5nCa5TwQ23fBq4cJjQ3fympU/JLcYO4opSmBHG5Ri7Pc0Z9CpqJE0L/yXScWh0e+ Jwu8Mz7/B6OkiwaPZQAElBkGLjZMTQ4F326qw0nbyU2WITF2LkWykgiZH3dgJt0Rx7qW XayIJ1yj0WhD3AlZHw5BPgPF2j6cfJB/Bjxp3/5PUphoIYPbwFoTqcsEyyij3vGLt1dk o6u9y0J13GzZm0MdOQXCFu95snwy+gorqAmoK9A6TnRP3t9Yp7c8zvefMV6/GqA8xDuz eKkcKbk0OD2h1noi7UyNL9XnTf78M0v8TUVetIOIUN7EdM+hS38uD8JGBD/1GNsRrqIO rtsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="CVRobaX/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z58si1491411edz.141.2019.11.13.06.40.53; Wed, 13 Nov 2019 06:41:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="CVRobaX/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727500AbfKMOkN (ORCPT + 99 others); Wed, 13 Nov 2019 09:40:13 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53951 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726957AbfKMOkN (ORCPT ); Wed, 13 Nov 2019 09:40:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573656012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bSHrFQsbaC1yAitK7Law8cbj6Z2ZKZzmHqlB5M3qljE=; b=CVRobaX/zg1fEGwJX5b9dR4DiYfTAwblF8YyXa0zxsw3TXDDx6d6b7pun6GJfBCYstgCm+ qLOTFc5eDUUdSe20ZcIjlNdqh1DI3oCcjLGlqi10NQ75o0zqd50uZWlBHi2OjYtQ3yDFj+ gCuvdHJoGG0Fn5S8LvLnnqOa1xr11NY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-yOlrfIIcMb-iBtVC6B25Hg-1; Wed, 13 Nov 2019 09:40:08 -0500 X-MC-Unique: yOlrfIIcMb-iBtVC6B25Hg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C76C8EDBC1; Wed, 13 Nov 2019 14:40:07 +0000 (UTC) Received: from localhost (ovpn-117-166.ams2.redhat.com [10.36.117.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id EBE4860C88; Wed, 13 Nov 2019 14:40:03 +0000 (UTC) Date: Wed, 13 Nov 2019 14:40:02 +0000 From: Stefan Hajnoczi To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, virtualization@lists.linux-foundation.org, miklos@szeredi.hu, dgilbert@redhat.com Subject: Re: [PATCH 3/3] virtiofs: Use completions while waiting for queue to be drained Message-ID: <20191113144002.GB554680@stefanha-x1.localdomain> References: <20191030150719.29048-1-vgoyal@redhat.com> <20191030150719.29048-4-vgoyal@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191030150719.29048-4-vgoyal@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8P1HSweYDcXXzwPJ" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8P1HSweYDcXXzwPJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 30, 2019 at 11:07:19AM -0400, Vivek Goyal wrote: > While we wait for queue to finish draining, use completions instead of > uslee_range(). This is better way of waiting for event. s/uslee_range()/usleep_range()/ --8P1HSweYDcXXzwPJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl3MFcIACgkQnKSrs4Gr c8iVMQgAlnZ9d6GvnmORD+LRCvqgvHMMUlFoZS9nF/QBnEG7N4Pqr8BPRJw7Gi0D uBdcZjReMZY2fG9ZNXoMA0ivvPUPa3eDEBeuXlQrp8Qw4yx32ciL9VYvKly8vvV2 2SMpOnsiuxDhldW2norjAP2piC7VCt+ni8x0yMTECQbaIfvrMhAxR/be/NWOj3pa RIFzuyeB4yqi73m0yRXtuN4AwL8Fzq/R0NFAfZDlGSiDmhWJ+xIJpPiL4ZfwVBaK hwzVPIkrA6TmDNNLtI7aCmVrQiA8lpnMH5FbKLmobmXjhedf4PwtiUEMSa3ESC6Y lBzMsJ4gnruQmDefdEdC1G7ohBHzSg== =47Ie -----END PGP SIGNATURE----- --8P1HSweYDcXXzwPJ--