Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423071AbWAMWyU (ORCPT ); Fri, 13 Jan 2006 17:54:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423072AbWAMWyU (ORCPT ); Fri, 13 Jan 2006 17:54:20 -0500 Received: from smtp.osdl.org ([65.172.181.4]:27609 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1423071AbWAMWyT (ORCPT ); Fri, 13 Jan 2006 17:54:19 -0500 Date: Fri, 13 Jan 2006 14:52:59 -0800 From: Andrew Morton To: Kumar Gala Cc: wim@iguana.be, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, iinuxppc-embedded@gate.crashing.org, dave@cray.org, paulus@samba.org Subject: Re: [PATCH] powerpc: Add support for the MPC83xx watchdog Message-Id: <20060113145259.6d38e296.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 25 Kumar Gala wrote: > > Added support for the PowerPC MPC83xx watchdog. The MPC83xx has a simple > watchdog that once enabled it can not be stopped, has some simple timeout > range selection, and the ability to either reset the processor or take > a machine check. > > > +static ushort timeout = 0xffff; There's no such thing ;) I'll change this to u16, OK? > +static int mpc83xx_wdt_ioctl(struct inode *inode, struct file *file, > + unsigned int cmd, > + unsigned long arg) Whitespace went nutty in various places. I'll fix that up. Please see the followup patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/