Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2120516ybc; Wed, 13 Nov 2019 09:16:17 -0800 (PST) X-Google-Smtp-Source: APXvYqznozA8ObfJUkhna1fk30h2vxrhB9+kl2qpTLFk+3yCdtmTgY16M5pHSZBltkZzP5J2D7og X-Received: by 2002:a17:906:d793:: with SMTP id pj19mr3876010ejb.303.1573665377751; Wed, 13 Nov 2019 09:16:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573665377; cv=none; d=google.com; s=arc-20160816; b=bEdJOSbwdYTyowEzFjwoLIErDsj7W39wnN3mAuP3737sJRAYm8HVw30o6kl+CqbtOh ZLIcMLhuww0I32mP/1mAUlkZzvIPX1ydS97bd0W0iCphegYcjrZJp3sQCt2/IWf5vz0a g+tF+s8K7HeKyZuq7k8V2Oq1eg17Q2jOS84itWg13cO1yV1zjOt6s2gtURzASHQ8PnNM HC9RALdS5zDK/TwMoz/Pi9yze4kvSQFTJXt7IyeJDqqCXzfSX5+mNjjaX0a5l3Yv2VCm V0aRNaTAPeEdYCTZyCutOn2LzM1L3/LWPtbdh5VjknWO9nfCRSRYuqZzVnCvVTvxn1Df m63w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=ViZkFUUwtX41jyhTGipRjvtm/b1fOmna08342oZ9TvQ=; b=ciSEeQbDVHYF/UWI9ecrtPx5/W02y1f/q+Xdxs4EUCSsd7CptUp0q2Qjuu697wuuQT noBAkM2FMXK+S0j7EFnNl2e/KfMt84qZE6ZYPfxHjlzz7ttXPw09Q+K1s9ZV0PwBLFfT um73hTrXycIb2lI0DVwDF6DqwfnM+IFvigEtJQSJUT8WjS4eLqVfabL/oN0ZG1RTFhk+ BPWPQASBSNHmrEFirD3Hk7WzTsn9FIOShdPJhYXnn3QAFmMRhlovZBMVzsNG1Q11wHEe twm6BBPstkBVlHDG5+zZ+D8V7AZl9IlNxCPlkIEGmtJeZxWfPEb19no5svFMBcyMgNYz mVZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=COBWHBka; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r7si1778910edy.16.2019.11.13.09.15.52; Wed, 13 Nov 2019 09:16:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=COBWHBka; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728434AbfKMQgr (ORCPT + 99 others); Wed, 13 Nov 2019 11:36:47 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:49752 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726410AbfKMQgr (ORCPT ); Wed, 13 Nov 2019 11:36:47 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xADGON4i180200; Wed, 13 Nov 2019 16:35:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=ViZkFUUwtX41jyhTGipRjvtm/b1fOmna08342oZ9TvQ=; b=COBWHBkaUQ0h8ZRfIjfIXNEoAtK2yY6bm4CB9utGr/XFMlrhujpizO8U9gG88bkviPQK WNXW+LTokzDqO8H7kdTH4YL4Bouo/UvAXIlk/ClRE2kHzTi4LgY1xlR7oP6REJsw/3Hr QO7S3NaKrDiVXtolTY85VDdvyKwq3f/77J8BYFCz2OnvAb0AILo/Lk0GhFkDQatX1HdN GhZiPi1dd4iu23O8OvoEI4faXEED+Pt4axxAaMQlUkj6Nn3BUDnscB4ahckpmcjhXTXU 3sqDALmVS4DNSliLooih91rLCaOWUIQS4+ewY8jWbk+xRqld8dRwuFL1NNKmJXuY9pTz 8w== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2w5p3qwjyu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Nov 2019 16:35:12 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xADGQtgE155926; Wed, 13 Nov 2019 16:35:12 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2w8g17sna1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Nov 2019 16:35:11 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xADGYwpb007489; Wed, 13 Nov 2019 16:34:58 GMT Received: from bostrovs-us.us.oracle.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Nov 2019 08:34:58 -0800 Subject: Re: [Xen-devel] [PATCH 2/3] xen/mcelog: add PPIN to record when available To: Jan Beulich Cc: Juergen Gross , the arch/x86 maintainers , "xen-devel@lists.xenproject.org" , lkml References: <9466c080-9926-0d9f-435a-ddf0c3ec7812@oracle.com> <5f8bbcb2-2eb9-c9f4-622a-43a6d0814b94@suse.com> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= mQINBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABtDNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT6JAjgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uuQINBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABiQIfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: Date: Wed, 13 Nov 2019 11:34:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <5f8bbcb2-2eb9-c9f4-622a-43a6d0814b94@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9440 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=832 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911130146 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9440 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=902 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911130146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/19 8:44 AM, Jan Beulich wrote: > On 13.11.2019 01:11, Boris Ostrovsky wrote: >> On 11/11/19 9:46 AM, Jan Beulich wrote: >>> --- a/arch/x86/include/asm/msr-index.h >>> +++ b/arch/x86/include/asm/msr-index.h >>> @@ -393,6 +393,8 @@ >>> #define MSR_AMD_PSTATE_DEF_BASE 0xc0010064 >>> #define MSR_AMD64_OSVW_ID_LENGTH 0xc0010140 >>> #define MSR_AMD64_OSVW_STATUS 0xc0010141 >>> +#define MSR_AMD_PPIN_CTL 0xc00102f0 >>> +#define MSR_AMD_PPIN 0xc00102f1 >> Which processors are these defined for? I looked at a couple (fam 15h >> and 17h) and didn't see those. And I don't see them in Linux. > Certain Fam17 ones, Rome in particular (which is where I've > tested this). I was looking at Naples, can't find Rome on AMD's page. > >>> --- a/include/xen/interface/xen-mca.h >>> +++ b/include/xen/interface/xen-mca.h >>> @@ -332,7 +332,11 @@ struct xen_mc { >>> }; >>> DEFINE_GUEST_HANDLE_STRUCT(xen_mc); >>> >>> -/* Fields are zero when not available */ >>> +/* >>> + * Fields are zero when not available. Also, this struct is shared with >>> + * userspace mcelog and thus must keep existing fields at current offsets. >>> + * Only add new fields to the end of the structure >>> + */ >>> struct xen_mce { >> Why is this structure is part of the interface? > That's a question to whoever put it there. There look to have > been decisions (see also patch 1) to have the Linux clones of > Xen's public headers deviate far more from their original > than I would consider reasonable. Yes, this goes back to when the file was first created. Reviewed-by: Boris Ostrovsky (but if you want to move non-interface parts into, say, drivers/xen/mcelog.h I won't stand in your way ;-) )