Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423077AbWAMW7Q (ORCPT ); Fri, 13 Jan 2006 17:59:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423081AbWAMW7Q (ORCPT ); Fri, 13 Jan 2006 17:59:16 -0500 Received: from gate.crashing.org ([63.228.1.57]:60554 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S1423077AbWAMW7P (ORCPT ); Fri, 13 Jan 2006 17:59:15 -0500 Date: Fri, 13 Jan 2006 16:50:35 -0600 (CST) From: Kumar Gala To: Andrew Morton cc: wim@iguana.be, , , , , Subject: Re: [PATCH] powerpc: Add support for the MPC83xx watchdog In-Reply-To: <20060113145259.6d38e296.akpm@osdl.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 32 On Fri, 13 Jan 2006, Andrew Morton wrote: > Kumar Gala wrote: > > > > Added support for the PowerPC MPC83xx watchdog. The MPC83xx has a simple > > watchdog that once enabled it can not be stopped, has some simple timeout > > range selection, and the ability to either reset the processor or take > > a machine check. > > > > > > +static ushort timeout = 0xffff; > > There's no such thing ;) I'll change this to u16, OK? There is one in include/linux/types.h, but u16 is fine. > > +static int mpc83xx_wdt_ioctl(struct inode *inode, struct file *file, > > + unsigned int cmd, > > + unsigned long arg) > > Whitespace went nutty in various places. I'll fix that up. Please see the > followup patch. Odd, no one else has had any issues with patches from me recently. - kumar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/