Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 13 Nov 2019 12:15:14 -0800 (PST)
Message-Id: <20191113.121514.218723445139450529.davem@davemloft.net>
To:     poeschel@lemonage.de
Cc:     gustavo@embeddedor.com, kstewart@linuxfoundation.org,
        opensource@jilayne.com, tglx@linutronix.de, swinslow@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        keescook+coverity-bot@chromium.org
Subject: Re: [PATCH net-next] nfc: pn533: pn533_phy_ops dev_[up,down]
 return int
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191113135039.32086-1-poeschel@lemonage.de>
References: <20191113135039.32086-1-poeschel@lemonage.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Lars Poeschel <poeschel@lemonage.de>
Date: Wed, 13 Nov 2019 14:50:22 +0100

> Change dev_up and dev_down functions of struct pn533_phy_ops to return
> int. This way the pn533 core can report errors in the phy layer to upper
> layers.
> The only user of this is currently uart.c and it is changed to report
> the error of a possibly failing call to serdev_device_open.
> 
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1487395 ("Error handling issues")
> Fixes: c656aa4c27b1 ("nfc: pn533: add UART phy driver")
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>

Applied, thanks Lars.