Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 13 Nov 2019 15:40:44 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Arnaldo Carvalho de Melo <acme@redhat.com>
Cc:     Hewenliang <hewenliang4@huawei.com>, tstoyanov@vmware.com,
        namhyung@kernel.org, linux-kernel@vger.kernel.org,
        linfeilong@huawei.com
Subject: Re: [PATCH] tools lib traceevent: Fix memory leakage in
 copy_filter_type
Message-ID: <20191113154044.5b591bf8@gandalf.local.home>
In-Reply-To: <20191113203710.GC3078@redhat.com>
References: <20191025082312.62690-1-hewenliang4@huawei.com>
        <20191113144626.44ad5418@gandalf.local.home>
        <20191113203710.GC3078@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 13 Nov 2019 18:37:10 -0200
Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Em Wed, Nov 13, 2019 at 02:46:26PM -0500, Steven Rostedt escreveu:
> > On Fri, 25 Oct 2019 04:23:12 -0400
> > Hewenliang <hewenliang4@huawei.com> wrote:
> >   
> > > It is necessary to free the memory that we have allocated
> > > when error occurs.
> > > 
> > > Fixes: ef3072cd1d5c ("tools lib traceevent: Get rid of die in add_filter_type()")
> > > Signed-off-by: Hewenliang <hewenliang4@huawei.com>  
> > 
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > 
> > Arnaldo,  
> 
> sure

I found an issue with it (if you didn't see the next email).

Please don't take it.

Thanks!

-- Steve

>  
> > Can you take this?
> > 
> > -- Steve
>