Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2382838ybc; Wed, 13 Nov 2019 13:37:05 -0800 (PST) X-Google-Smtp-Source: APXvYqwKS/m/nU8i6vJJzSLpZkHAV9nKyE49ArJN/G8OfsU8llU5wktUczX+ASNMafgMdkYfTAWi X-Received: by 2002:a05:6402:1006:: with SMTP id c6mr6207306edu.2.1573681025385; Wed, 13 Nov 2019 13:37:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1573681025; cv=pass; d=google.com; s=arc-20160816; b=nM+w4GmOisIj3uCahO3az5oW2xSkDqdRyyWfTski0eF22yl4uLQaSGM8kfPm85s/Cv EvVB4HWFuCnWpSzsH63Ee6VZzSvsZ9OaqeDxFW81RtRvsSklopmeOj1LgzcZiLtHWeQZ elT4YkaqjX4PO4VR1Uez+CtzmX/Rq1bkvPfyDshVFPvmK8JValn8jGPL3nmx2y1LckPQ Esa71MYZWw/qbFCKrrGbvaf79D7s1AQuUD+u9WC9wfv4MGMjW3dTKoPJ2kEFqTr+1Wr+ 8O3Rf0HUtIktXLChTXyqPfG4FNbSJt4wDZuFb9wbmSWTsc+3zxcLm0e7nRGcPmVKQro+ 2aPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=OTM1FccH4BJmJJgiKw6PubKfPhaeyfWDRX+GgnBSJbs=; b=QnHq/ULDq1mKTic0zFagjPpnEEgzxeweR4u+Jx+mxMERHMv2RR/P3wRx35/v5fhCzM 74rh6Qa7ElaA+30Z0x6PGk/EiYffABhZ+7dWohuFePzcXkKkXjZpYZGyclHBiJzBQSnh EyZaMWHkL8nGpfSbPf9c2KmJ4YbSlR3liUqx5ebUMgLmwZGtTHCOU+kcKaV2X900WrIG BBJfI714oDOdys/0hUBHy31RuCL3Pzz6kW6gtevcZ0FB+4XdLqm7U7Cmx8sAAcQdc5Vi hTNEv/3shFCxV6qn0Y7SwPjoYqwEExHzt7rPJh/btKTZq8b78rtBC1cRDEWuejemGLzg aQxQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@micron.com header.s=selector2 header.b=f5VmTYBy; arc=pass (i=1 spf=pass spfdomain=micron.com dkim=pass dkdomain=micron.com dmarc=pass fromdomain=micron.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=micron.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jt21si1900845ejb.390.2019.11.13.13.36.40; Wed, 13 Nov 2019 13:37:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@micron.com header.s=selector2 header.b=f5VmTYBy; arc=pass (i=1 spf=pass spfdomain=micron.com dkim=pass dkdomain=micron.com dmarc=pass fromdomain=micron.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=micron.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbfKMVf4 (ORCPT + 99 others); Wed, 13 Nov 2019 16:35:56 -0500 Received: from mail-eopbgr690089.outbound.protection.outlook.com ([40.107.69.89]:11254 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726162AbfKMVfz (ORCPT ); Wed, 13 Nov 2019 16:35:55 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b9gAj9Q3XDoDzSBNEwSnjkpUbPw3u6kIcIkws/m5OJJRS5Wqu5dJI5F9ewdgaEZ5xuOaRGtu7sFdYC3Xoj0i42y+Y1sIIU/xb54abq0cwXOspUL2b2G+gx0n3HaznGcoytzjuT+fSW02gE94mYtgJUm2bZJhN+s4LHDbzBxdU5o4g2BKrSoOEliTjA/2RYR38t1HpATFnroyuc3mamuUB9w4H5sDUeRctq51nuZvd6rF7Ck0bd+VbTfK0QzrsPbzyRccejdKbfqzitYVoS7roNHlq++5BgtPvdf1QKPvfsQSfV1jO40MXTezWGmibKyQagjN8rZN3QROGM1T1OHo2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTM1FccH4BJmJJgiKw6PubKfPhaeyfWDRX+GgnBSJbs=; b=i9AT/8XwxKsGqY5JZRKwznCFhU6Bn3f0icBD0JFkHnDa70L/JGq7s99lGn0/FHtpJxcTs64ij/o2K23ZdmX4Pc1Ewta/k8o25xo2WyFt2iCQhPm6ji9gwQAMLfZ0seylzujETes5AUIFQRJzgYOoq8OQ0ZbiwqpHB6kPj/vSTgXpQyYZ8VTiS3Ejh67/JaQnUsEvb2rKX+WhxdAUMa1I5YnbZH8IAOK269cTQScrFMEgP9x+zic6jB8ArjyetAeP0lsIMz7D4wk2nCNp5BZbJ4a4zcF1L5n6fySyn4yhnYhtMPBxmZ6FC9VgctWKWrjTBaE2/5IRlqE1vam6tA2dWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=micron.com; dmarc=pass action=none header.from=micron.com; dkim=pass header.d=micron.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=micron.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTM1FccH4BJmJJgiKw6PubKfPhaeyfWDRX+GgnBSJbs=; b=f5VmTYByAgUmHFXmLh6ab2GEB6BoonTZ1IViO2NEfkh/MyQWImjGQkdeZPWGK8x8gDwJuR0+V8hii4CRDXcxvL3icamwSH08R3Js/3XgUCJnJP7b/t6uj6sVYU+rlsYEhQI3oqwl9WNiiGQoUSnznhgt3ghi/SCi0R8eyNlz5+Q= Received: from BN7PR08MB5684.namprd08.prod.outlook.com (20.176.179.87) by BN7PR08MB3859.namprd08.prod.outlook.com (52.132.5.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Wed, 13 Nov 2019 21:35:53 +0000 Received: from BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::a91a:c2f5:c557:4285]) by BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::a91a:c2f5:c557:4285%6]) with mapi id 15.20.2430.028; Wed, 13 Nov 2019 21:35:52 +0000 From: "Bean Huo (beanhuo)" To: Can Guo , "asutoshd@codeaurora.org" , "nguyenb@codeaurora.org" , "rnayak@codeaurora.org" , "linux-scsi@vger.kernel.org" , "kernel-team@android.com" , "saravanak@google.com" , "salyzyn@google.com" CC: Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Subhash Jadavani , Tomas Winkler , open list Subject: RE: [EXT] [PATCH v1 1/5] scsi: ufs: Recheck bkops level if bkops is disabled Thread-Topic: [EXT] [PATCH v1 1/5] scsi: ufs: Recheck bkops level if bkops is disabled Thread-Index: AQHVlgy8Ub+viGdtoUi1bbnuqokAjqeJo3lg Date: Wed, 13 Nov 2019 21:35:52 +0000 Message-ID: References: <1573200932-384-1-git-send-email-cang@codeaurora.org> <1573200932-384-2-git-send-email-cang@codeaurora.org> In-Reply-To: <1573200932-384-2-git-send-email-cang@codeaurora.org> Accept-Language: en-150, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYmVhbmh1b1xhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLThmMGJkZjQ0LTA2NWQtMTFlYS04Yjg1LWRjNzE5NjFmOWRkM1xhbWUtdGVzdFw4ZjBiZGY0NS0wNjVkLTExZWEtOGI4NS1kYzcxOTYxZjlkZDNib2R5LnR4dCIgc3o9IjgzMCIgdD0iMTMyMTgxNTQ1NTAwNjI4NTE2IiBoPSJZR3pPdlhVUzZSSDUxSFB4d2xyaWc0YWhmbDA9IiBpZD0iIiBibD0iMCIgYm89IjEiLz48L21ldGE+ x-dg-rorf: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=beanhuo@micron.com; x-originating-ip: [165.225.81.26] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c94b769d-9a03-4ebf-9f0d-08d768817594 x-ms-traffictypediagnostic: BN7PR08MB3859:|BN7PR08MB3859:|BN7PR08MB3859: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 0220D4B98D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(199004)(189003)(81156014)(81166006)(8936002)(7416002)(2201001)(110136005)(66446008)(86362001)(3846002)(316002)(6436002)(74316002)(305945005)(9686003)(6116002)(4326008)(2906002)(55016002)(8676002)(66946007)(5660300002)(256004)(14444005)(64756008)(52536014)(99286004)(76116006)(71200400001)(71190400001)(54906003)(66476007)(66556008)(4744005)(66066001)(478600001)(7696005)(102836004)(14454004)(76176011)(229853002)(25786009)(7736002)(26005)(476003)(446003)(11346002)(6246003)(186003)(33656002)(6506007)(2501003)(486006)(55236004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR08MB3859;H:BN7PR08MB5684.namprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: micron.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nVbMIdeAQrQwiysEYJKPBlK+rDwlIg+a9+HTiamqJl9CjvMlI538MXv2LEGDn/f7yODo3L3oSfugYHds8j5FR3W/khhPnOucealCtD0HIBchm0Of9uYK/HwPOQ7TerQDjjjCergwM0gamp6UHiObvW9cyWzrHPJclavCk5usW8x/zsBIfcez7JCB2odJaZKBlxr0FwpJUBFGQVnggmgM3U2jlkT1UlSMmvnRiTShG4evd+yRztsuMkdFyOqtgkFh3/S7gCUlxoQqoO3SLb5TWDpn1jgy0mwnzcnngQ3oCYv147wIjIoze+FDq0RkMIT8ge5AyTHC5WxgAxUqv6w1bw/BuyrENiFkbmflZTJ5zxG/P9vLJ6LkhJ1fAhRksdqv0lDdvZZNi8sPZdwHkifSvPJplavSLT9yKSmMo57rAEW0zniCuOHB8tlbg33vNaho Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: micron.com X-MS-Exchange-CrossTenant-Network-Message-Id: c94b769d-9a03-4ebf-9f0d-08d768817594 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2019 21:35:52.7905 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kwrUkws3HHetzgblvjUEObkRqIAdy+ewy/ZwhX0oW6TXH2ihAEq/bV/IIOJMlBJjOXvNkw5MK5NEhOiPpB6UHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR08MB3859 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Subject: [EXT] [PATCH v1 1/5] scsi: ufs: Recheck bkops level if bkops is = disabled >=20 > From: Asutosh Das >=20 > Bkops level should be rechecked upon receiving an exception. > Currently the bkops level is being cached and never updated. >=20 Yes, this makes sense, once receiving a bkops exception, we should recheck = its level. Because device side has changed its status. > Update the same each time the level is checked. > Also do not use the cached bkops level value if it is disabled and then e= nabled. >=20 should use current level. > Signed-off-by: Asutosh Das > Signed-off-by: Can Guo Reviewed-by: Bean Huo