Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2465341ybc; Wed, 13 Nov 2019 15:03:03 -0800 (PST) X-Google-Smtp-Source: APXvYqxG5Z+D62dsj1jVnJ7q8DLSWpbu9rvigdgB9eBHrCphDuXOzRe0S7dDivoLV2uLQET+GbzP X-Received: by 2002:a05:6402:104c:: with SMTP id e12mr6435760edu.199.1573686183799; Wed, 13 Nov 2019 15:03:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573686183; cv=none; d=google.com; s=arc-20160816; b=GT1NZNCA/oQPdfsXuLAEUMH8QGwmDCFJr/6jTEBl1DBuAPKPUW23weTfmEH108ucVm elNRSPhr0j362Zp6DkrstBymN2gHFB5Rae81pvoHbeZGU90hd/Eg/PYJOQj+oocJ/dDk E2MDTWM3q1JChQP7RBeN/yDow71nyE5WdBH8bOMLtopTcA3nEXCkfMYU5sAJwnRIBcf8 OyEc8apGXzAW80GCfm30iwzfZFWIyj/TEdYiFJKb9Cna5nz+77VNaXDl4YJb5CA/xT/E A7cnIKlZtd3+2rhUpXMugRJjbOM8bTikgL+iSWlDvTa38nmSEL4qsgEs5L3UY8QVGmRA m8zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:user-agent:in-reply-to:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Jhvq/7L4CZ926SBn146xoHM4iaITra2Z+/5GmzTdYcE=; b=EkuRWV/JPX8dn0uKpFnsqvI9i8U9AdJdWjJcx6Pq8/eiPyjUL8KRCzulcQvRtZZlNW l5Mb3TbsCnytBPTLHEBNmfMSPCtYjR6SWD1tsgmAkFKSdN9jo7T/b0Lj3W3MKdKgMQUy BLXFwi6RFac2NPL+7S0PrwIQ/Dr+5/IFkvI4kZPFCuGNAjPNMhnHEjQjI2nYkj3wkum4 /O2BGNseuHZIF8N3JmpTSyfUnDUJReV/IIDZVhACR3EoWFqbvjZ4jK30KvUJO6mbBRZ2 sLcIY754uCBxKvRFnxhy9Qlor9C3ETc+dYQQgvyuZlL3mTg9DVi+dvkWwYVrbtfZB+Xz mOsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DJsHtAOW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si2091879eji.232.2019.11.13.15.02.36; Wed, 13 Nov 2019 15:03:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DJsHtAOW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbfKMXCA (ORCPT + 99 others); Wed, 13 Nov 2019 18:02:00 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:46840 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726303AbfKMXCA (ORCPT ); Wed, 13 Nov 2019 18:02:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573686119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jhvq/7L4CZ926SBn146xoHM4iaITra2Z+/5GmzTdYcE=; b=DJsHtAOWRncdK0lLalXO/UBto7UO+3z4sEzZ5ewyuGJBoFWkkp5uEiZSy80sINhkJTdYsx QuSbrqbcAHOuU9a7DWPQeT5lXaTr1BiJYGq/BEYGTcXMx4GNXyS85Ln5pPfhrfTXdTfl4e wLNtzOsjrcvKXEriETWcpLIK0CEJuGs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-117-NMLHO3wPOZCehLy3t-Rx9g-1; Wed, 13 Nov 2019 18:01:56 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AD73107ACC5; Wed, 13 Nov 2019 23:01:55 +0000 (UTC) Received: from sandy.ghostprotocols.net (ovpn-112-24.phx2.redhat.com [10.3.112.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1CC531001B28; Wed, 13 Nov 2019 23:01:53 +0000 (UTC) Received: by sandy.ghostprotocols.net (Postfix, from userid 1000) id 81BCB11E8; Wed, 13 Nov 2019 21:01:49 -0200 (BRST) Date: Wed, 13 Nov 2019 21:01:49 -0200 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Hewenliang , tstoyanov@vmware.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, linfeilong@huawei.com Subject: Re: [PATCH] tools lib traceevent: Fix memory leakage in copy_filter_type Message-ID: <20191113230149.GA8999@redhat.com> References: <20191025082312.62690-1-hewenliang4@huawei.com> <20191113144626.44ad5418@gandalf.local.home> <20191113203710.GC3078@redhat.com> <20191113154044.5b591bf8@gandalf.local.home> MIME-Version: 1.0 In-Reply-To: <20191113154044.5b591bf8@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: NMLHO3wPOZCehLy3t-Rx9g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Nov 13, 2019 at 03:40:44PM -0500, Steven Rostedt escreveu: > On Wed, 13 Nov 2019 18:37:10 -0200 > Arnaldo Carvalho de Melo wrote: >=20 > > Em Wed, Nov 13, 2019 at 02:46:26PM -0500, Steven Rostedt escreveu: > > > On Fri, 25 Oct 2019 04:23:12 -0400 > > > Hewenliang wrote: > > > =20 > > > > It is necessary to free the memory that we have allocated > > > > when error occurs. > > > >=20 > > > > Fixes: ef3072cd1d5c ("tools lib traceevent: Get rid of die in add_f= ilter_type()") > > > > Signed-off-by: Hewenliang =20 > > >=20 > > > Reviewed-by: Steven Rostedt (VMware) > > >=20 > > > Arnaldo, =20 > >=20 > > sure >=20 > I found an issue with it (if you didn't see the next email). >=20 > Please don't take it. =20 ok. > Thanks! >=20 > -- Steve >=20 > > =20 > > > Can you take this? > > >=20 > > > -- Steve > >