Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Nov 2019 02:08:05 +0300
From:   Andrey Skvortsov <andrej.skvortzov@gmail.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Alessandro Zummo <a.zummo@towertech.it>, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: tps65910: allow using RTC without alarm interrupt
Message-ID: <20191113230805.GH13629@skv.local>
Mail-Followup-To: Andrey Skvortsov <andrej.skvortzov@gmail.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Alessandro Zummo <a.zummo@towertech.it>, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20191109154652.7419-1-andrej.skvortzov@gmail.com>
 <20191111171915.GA3572@piout.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="HYC+c85AsWjroYih"
Content-Disposition: inline
In-Reply-To: <20191111171915.GA3572@piout.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--HYC+c85AsWjroYih
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 19-11-11 18:19, Alexandre Belloni wrote:
> Hi,
>=20
> This needs a proper commit message.

Add in v2.
=20
> On 09/11/2019 18:46:52+0300, Andrey Skvortsov wrote:
> > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> > ---
> >  drivers/rtc/rtc-tps65910.c | 19 +++++++++++++++----
> >  1 file changed, 15 insertions(+), 4 deletions(-)
> >=20
> > diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
> > index 2c0467a9e717..aa3a001ef413 100644
> > --- a/drivers/rtc/rtc-tps65910.c
> > +++ b/drivers/rtc/rtc-tps65910.c
> > @@ -361,6 +361,13 @@ static const struct rtc_class_ops tps65910_rtc_ops=
 =3D {
> >  	.set_offset	=3D tps65910_set_offset,
> >  };
> > =20
> > +static const struct rtc_class_ops tps65910_rtc_ops_noirq =3D {
> > +	.read_time	=3D tps65910_rtc_read_time,
> > +	.set_time	=3D tps65910_rtc_set_time,
> > +	.read_offset	=3D tps65910_read_offset,
> > +	.set_offset	=3D tps65910_set_offset,
> > +};
> > +
> >  static int tps65910_rtc_probe(struct platform_device *pdev)
> >  {
> >  	struct tps65910 *tps65910 =3D NULL;
> > @@ -415,13 +422,17 @@ static int tps65910_rtc_probe(struct platform_dev=
ice *pdev)
> >  		tps65910_rtc_interrupt, IRQF_TRIGGER_LOW,
> >  		dev_name(&pdev->dev), &pdev->dev);
> >  	if (ret < 0) {
> > -		dev_err(&pdev->dev, "IRQ is not free.\n");
> > -		return ret;
> > +		dev_err(&pdev->dev, "request IRQ:%d failed, err =3D %d\n",
> > +			 irq, ret);
>=20
> Do we actually need an error message here?

You are right. This is definitely not an error anymore.
What about
dev_warn(&pdev->dev, "unable to request IRQ, alarms disabled\n");
like some other drivers do?


grep -RHn 'unable to request IRQ, alarms disabled'
rtc-rv8803.c:576:			dev_warn(&client->dev, "unable to request IRQ, alarms d=
isabled\n");
rtc-m41t80.c:914:			dev_warn(&client->dev, "unable to request IRQ, alarms d=
isabled\n");
rtc-rv3028.c:651:			dev_warn(&client->dev, "unable to request IRQ, alarms d=
isabled\n");
rtc-pcf85363.c:416:			dev_warn(&client->dev, "unable to request IRQ, alarms=
 disabled\n");
rtc-pcf85063.c:458:				 "unable to request IRQ, alarms disabled\n");
rtc-rv3029c2.c:828:			dev_warn(dev, "unable to request IRQ, alarms disabled=
\n");
rtc-rx8025.c:540:			dev_err(&client->dev, "unable to request IRQ, alarms di=
sabled\n");
rtc-abx80x.c:839:			dev_err(&client->dev, "unable to request IRQ, alarms di=
sabled\n");


>=20
> > +		irq =3D -1;
> >  	}
> >  	tps_rtc->irq =3D irq;
> > -	device_set_wakeup_capable(&pdev->dev, 1);
> > +	if (irq !=3D -1) {
> > +		device_set_wakeup_capable(&pdev->dev, 1);
> > +		tps_rtc->rtc->ops =3D &tps65910_rtc_ops;
> > +	} else
> > +		tps_rtc->rtc->ops =3D &tps65910_rtc_ops_noirq;
> > =20
> > -	tps_rtc->rtc->ops =3D &tps65910_rtc_ops;
> >  	tps_rtc->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000;
> >  	tps_rtc->rtc->range_max =3D RTC_TIMESTAMP_END_2099;
> > =20
> > --=20
> > 2.20.1
> >=20
>=20
> --=20
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

--=20
Best regards,
Andrey Skvortsov

--HYC+c85AsWjroYih
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEQ575tvhxWSXeo3tPAXzLovVIsK0FAl3MjM8ACgkQAXzLovVI
sK1lPxAAvSdgY5bOXPlM53wypSyBxGTbjygKd3QmKLR+vK9Oj+RnmCkWM3IML1Kc
TsaGKqqinXuiTi5xCV5aH0MTNetcFkqvr2yrQ0oQYLqBKQcF2rwgV6h4FHsai4Jd
30s4sbXB5Pr2VI2DWWo9WwQwS4tj4llNiFvKJzaPX9OSWOOOfyBMjrdx0ht4S+cx
DsJrGyMzkuVhwHgagsN0j2KAr+aPqDW8kWof01jHVJFnUCiTawr9UWo5WREMA2ex
8lpvICaIEAqouXrtG3F3rK0UBqXapYtVwRwOcGF0TmlExpz+OFYmph2caUx7EwUr
QsHRECRDpmKOad2dDZ0EcyyYk+AdCfHAEnsFOvN5TnjATNgB0tR9v9HAg9IZ+79b
TisDorXh+Lco2l0NMVsVxB9xBepBLhyKIA4PYychMPwrylVHc7CyooQkWBccB9Gv
8hB/wjjlS4y/DhSh00WbZHcdYRA7uCbdbPE8G/rCzfPbdmui3pICxKRHL4sWDqrv
xOiNKm/Bv+01JLmzehs9HeNoI1UTCAAmBpy/y1/hJwLanxAq7htSkddn6UCj2b8K
RtxnN0EAa9yq9m+3+DdtCraG7Jh4OVn8RqW28Av/VpXdrj1Nar8Y13BKZ5pTugiU
6JPbNlt3BBeZZITRkBsE0uPDIMNh8AeFOVh0oD+s0AFsi6gHbN0=
=V66C
-----END PGP SIGNATURE-----

--HYC+c85AsWjroYih--