Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Nov 2019 00:26:09 +0000
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Mark Salyzyn <salyzyn@android.com>
Cc:     linux-kernel@vger.kernel.org, kernel-team@android.com,
        Tim Murray <timmurray@google.com>,
        Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2] firmware_class: make firmware caching configurable
Message-ID: <20191114002609.GC11244@42.do-not-panic.com>
References: <20191113210124.59909-1-salyzyn@android.com>
 <20191113225429.118495-1-salyzyn@android.com>
 <20191113231602.GB11244@42.do-not-panic.com>
 <33f2baa2-944a-2bfc-1c50-0e437bf11959@android.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <33f2baa2-944a-2bfc-1c50-0e437bf11959@android.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 13, 2019 at 04:16:38PM -0800, Mark Salyzyn wrote:
> On 11/13/19 3:16 PM, Luis Chamberlain wrote:
> > On Wed, Nov 13, 2019 at 02:54:26PM -0800, Mark Salyzyn wrote:
> > > +config FW_CACHE
> > > +	bool "Enable firmware caching during suspend"
> > > +	depends on PM_SLEEP
> > > +	default y if PM_SLEEP
> > I think the default y would suffice given you have depends on PM_SLEEP,
> > however this also works. So, again:
> > 
> > Acked-by: Luis Chamberlain <mcgrof@kernel.org>
> > 
> >    Luis
> 
> Worried about setting FW_CACHE w/o PM_SLEEP, this enforces it.

I understand, but its an impossibility to turn on FW_CACHE without
PM_SLEEP since it depends on it. How would one do that?

However, since it makes no difference we can leave it.

  Luis