Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2616824ybc; Wed, 13 Nov 2019 18:07:39 -0800 (PST) X-Google-Smtp-Source: APXvYqxTNQ6UvbNqCsoaWJl5E3gPeTJxZS8E9nAxlAi7O7jpntsvu6WaEDO98dtpZuaRviH5y4It X-Received: by 2002:a17:906:22c9:: with SMTP id q9mr6027051eja.198.1573697259125; Wed, 13 Nov 2019 18:07:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573697259; cv=none; d=google.com; s=arc-20160816; b=gyRFvQyMusSHUU0AHRmzW5ktqYftRNmtKXv1eY+tvTMAmvsyudnlYr6sue5hEu3hce TDhRUmewZe4Wd533nMS4M0kNjvYqinHv7AyflZXnSdvxKpvmXQenteCshEJtadVMhaiE 6AWb4o66kmFs9yMYO+2st2/gdCC8DqYuU5/tcHw8A5Rh+1igkEN8cDKu158Tp0h0Lq55 Xs12iVHZBdFTSvAnwXry6INCphHEh1Xahvc6MH9QefDjYPzqlAsacZIUfNFeGNjElnra PqtB4Wcsw2+hxVpYGS1MwRQZWqT388sT79zemJoYUNei3kW+mXJqcnayqtdbv5eBIail Tclw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=fVnXsIh3anNxx06WlPrUSlFYkHezKwf/WKqPblf006g=; b=wmzXFXnF1mGOP7jz9IgcllAYoZa+FO/VfMdDexEHVIs01FIqYDmOd5GiMrAUsgmMrn HZyUFiNpwwKaXKS7n2b5YEBJ4exC1IjfK9or+1Jqy9+gA17iIwSiZjHp9zON5m9yJG7x rZOZhI+9A+BCtmXxrEgEkmWvIIM7hGyLwecyKWaPjobG/qyK60r86g/COJCDKHxwMN5w N111JilvCM9ruC/nmiBknEvIX7XbK6iMC2XfYaz4ytCeepO/4XCzkGNHdxh95+WXPusA vk4aAjEzsakLxJJDT35S0KGu8/XH6IK+U/uB8HiGFYdxqXACbugobal+Llxxq+QKz5D/ QMQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5si2647352edq.173.2019.11.13.18.07.14; Wed, 13 Nov 2019 18:07:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfKNCGO (ORCPT + 99 others); Wed, 13 Nov 2019 21:06:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:47500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726335AbfKNCGO (ORCPT ); Wed, 13 Nov 2019 21:06:14 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91526206F3; Thu, 14 Nov 2019 02:06:13 +0000 (UTC) Date: Wed, 13 Nov 2019 21:06:11 -0500 From: Steven Rostedt To: Thomas Gleixner Cc: Arnd Bergmann , y2038@lists.linaro.org, Ingo Molnar , linux-kernel@vger.kernel.org, Anna-Maria Gleixner , Frederic Weisbecker , "Peter Zijlstra (Intel)" , Kees Cook Subject: Re: [PATCH 21/23] y2038: itimer: change implementation to timespec64 Message-ID: <20191113210611.515868a4@oasis.local.home> In-Reply-To: References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-12-arnd@arndb.de> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Nov 2019 23:28:47 +0100 (CET) Thomas Gleixner wrote: > On Fri, 8 Nov 2019, Arnd Bergmann wrote: > > TRACE_EVENT(itimer_state, > > > > - TP_PROTO(int which, const struct itimerval *const value, > > + TP_PROTO(int which, const struct itimerspec64 *const value, > > unsigned long long expires), > > > > TP_ARGS(which, value, expires), > > @@ -321,12 +321,12 @@ TRACE_EVENT(itimer_state, > > __entry->which = which; > > __entry->expires = expires; > > __entry->value_sec = value->it_value.tv_sec; > > - __entry->value_usec = value->it_value.tv_usec; > > + __entry->value_usec = value->it_value.tv_nsec / NSEC_PER_USEC; > > __entry->interval_sec = value->it_interval.tv_sec; > > - __entry->interval_usec = value->it_interval.tv_usec; > > + __entry->interval_usec = value->it_interval.tv_nsec / NSEC_PER_USEC; > > Hmm, having a division in a tracepoint is clearly suboptimal. Right, we should move the division into the TP_printk() __entry->interval_nsec = alue->it_interval.tv_nsec; > > > ), > > > > - TP_printk("which=%d expires=%llu it_value=%ld.%ld it_interval=%ld.%ld", > > + TP_printk("which=%d expires=%llu it_value=%ld.%06ld it_interval=%ld.%06ld", > > We print only 6 digits after the . so that would be even correct w/o a > division. But it probably does not matter much. Well, we still need the division in the printk, otherwise it will print more than 6. That's just the minimum and it will print the full number. __entry->interval_nsec / NSEC_PER_USEC -- Steve > > > @@ -197,19 +207,13 @@ static void set_cpu_itimer(struct task_struct *tsk, unsigned int clock_id, > > #define timeval_valid(t) \ > > (((t)->tv_sec >= 0) && (((unsigned long) (t)->tv_usec) < USEC_PER_SEC)) > > Hrm, why do we have yet another incarnation of timeval_valid()? Can we > please have only one (the inline version)? > > Thanks, > > tglx