Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2671919ybc; Wed, 13 Nov 2019 19:25:26 -0800 (PST) X-Google-Smtp-Source: APXvYqwfNYbR+uOhEyKYJppKKkLePfrMzmHyvXGaj1d1fp1GlOy1l1pG+v86/XoxNg59QH9GNwfT X-Received: by 2002:a50:fb8d:: with SMTP id e13mr7366522edq.213.1573701926047; Wed, 13 Nov 2019 19:25:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573701926; cv=none; d=google.com; s=arc-20160816; b=Mxa1X9TsIiI1inSDW0oEPccYDpVYJ0Dmy7NA6eyzFjyjqpYFQfvzye666LrJzn5O3m tUuNbelfscuYPKKhYgGplSL4u1ps0rA7/Az9/EoFz2y1Ksdk8Ye1ra8Ws+fniXvikXqM tl8VLUqYbf38i2OlQSOZfvsUyt2WEV3iUDmuM+8y37gEndbmxH2UddKgElys3z4gobzE pAqKN//x+4mYdbbeTsNpwXj1toXeIolRUlIrq1asnT5dzhewHhUk1pwz1lv8MHXeGwrS riUmIGtzlk+AtHhnPaIthH6DfTOqyM06WUcws/wpOaV8U6BMZCJraCjL4kc/6H0t073c MFFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LOC2vOcr/gPbRqGn2Hv/uKpoW3Z1on+cOsepby22I4o=; b=hil7dkqkee/H7tbyLrjbFKxCIB5JVIQvwdLZumIEh49HoGo2hDVem2jORnIJxHvVwP QOk7pG6qD7+QfbLffzhs+nmK5hLC8yrSvZ4p3b8IoGIhKAQXRTrVxV+rt86jv02JPAeQ JkS5FfeouXJuZjzP9cNwutQ/x7aupFFvlmYULXB24nXpqCw0Lxd5w1GR0YQDNj/AhPru /MrCSSWOqcs0igS6y1JIxpttjoOuCA2BDDupj2/icDiv3uL97X5G4ZeySspEbgF/scLF 4xMqnM2LZG5oIN1+dlb3jmFH2unOWYr/tBQxzx7HL+bqIHSlVKAEuOOH4MqGe3qFamOC mOeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2ZZqboLM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p29si3338647eda.104.2019.11.13.19.25.01; Wed, 13 Nov 2019 19:25:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2ZZqboLM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbfKNDVV (ORCPT + 99 others); Wed, 13 Nov 2019 22:21:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:59584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726491AbfKNDVV (ORCPT ); Wed, 13 Nov 2019 22:21:21 -0500 Received: from localhost (unknown [124.219.31.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FC8A206F3; Thu, 14 Nov 2019 03:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573701680; bh=FmT+xIiI8fjMzRISC6E96FWJYAdkxpETep6dx0aAOFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2ZZqboLMJesjq8BgSJ7MoVJfF7TgnYS/cpHL36P4jLxMYovM+i28jf1w3HevubntO CeDfpE3nKYFUIcb2Vwhkjbuo4IYsEvU7SVWvJfBdlElMiMJ5CCs+VgGXsWTotdq/qS w53jwTQdO8muQEOIrztPV0CPbjIZ2Oh5POjkNcYQ= Date: Thu, 14 Nov 2019 11:21:17 +0800 From: Greg Kroah-Hartman To: Chunfeng Yun Cc: Felipe Balbi , Laurent Pinchart , Mauro Carvalho Chehab , Peter Chen , Minas Harutyunyan , Cristian Birsan , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kevin Cernekee , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Bin Liu , Matthias Brugger , Stephen Boyd , Yoshihiro Shimoda , Colin Ian King , Biju Das , Fabrizio Castro , "Gustavo A. R. Silva" , Yangtao Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 12/13] usb: gadget: udc: gr_udc: create debugfs directory under usb root Message-ID: <20191114032117.GA130252@kroah.com> References: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> <1573541519-28488-12-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1573541519-28488-12-git-send-email-chunfeng.yun@mediatek.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 12, 2019 at 02:51:58PM +0800, Chunfeng Yun wrote: > Now the USB gadget subsystem can use the USB debugfs root directory, > so move it's directory from the root of the debugfs filesystem into > the root of usb > > Signed-off-by: Chunfeng Yun > --- > v2: > 1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root > --- > drivers/usb/gadget/udc/gr_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c > index 7a0e9a58c2d8..5faa09a6c770 100644 > --- a/drivers/usb/gadget/udc/gr_udc.c > +++ b/drivers/usb/gadget/udc/gr_udc.c > @@ -208,7 +208,7 @@ static void gr_dfs_create(struct gr_udc *dev) > { > const char *name = "gr_udc_state"; > > - dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL); > + dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); > debugfs_create_file(name, 0444, dev->dfs_root, dev, &gr_dfs_fops); > } > This breaks the build: drivers/usb/gadget/udc/gr_udc.c: In function ‘gr_dfs_create’: drivers/usb/gadget/udc/gr_udc.c:211:57: error: ‘usb_debug_root’ undeclared (first use in this function) 211 | dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); | ^~~~~~~~~~~~~~ drivers/usb/gadget/udc/gr_udc.c:211:57: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:265: drivers/usb/gadget/udc/gr_udc.o] Error 1 so I've dropped it from the patch series. Please fix up and resend. And of course, always test-build your patches before you send them out... greg k-h