Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2682186ybc; Wed, 13 Nov 2019 19:39:19 -0800 (PST) X-Google-Smtp-Source: APXvYqx/eBK8PcMusGXc3nw18EfbAs1Taj4HQ+3XfrdA69Og4fkI5oQij4Lczi45C8ghFm0AIxFw X-Received: by 2002:a17:906:fcdb:: with SMTP id qx27mr5560306ejb.255.1573702759379; Wed, 13 Nov 2019 19:39:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1573702759; cv=pass; d=google.com; s=arc-20160816; b=iBphz9Cd3Qz5aYUGVvpO3B8X+fWpaPUHjPE2uV2QGXyDYsoGK6IxdHEwRnmxjBsvY9 aYu3qKWqo0CAn0kEOzI7qSsgBj9T/+QECOmJG77LwVqvFWiZOjZloLiPL9SrjBL5LgiU PF6hZNkj6CIzcxoGNp86KC0NfWXvTRuCCi2fqKdmhvdPLM7rmmrAReDksWGipIzOXwnC +XXloRIIK/44R3WGxQlOcrEnKihtU2E6x8b7dS6PV2SBTbUF3iBfXvu7x+BQe+Lp9r0p IGeEXa77NTn/TVzP3yPncQx9lPAe3A6AircODK6IGrJ29qdAFzfNNSI6HZmHAmLo9ZGy qXSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=A2EkBPnFwsWwCoy3O91Sga15UCfRLu1FZh+B5Qejowk=; b=DRRGQVb3wFz+oVqk6d9rEcgjCiRRZD26YqyaolipM9HQQzr+eYquvcX6Hom29QroGO Jhzo7hefjYwKo+5gj91OR8hw5/YQ/erBT3eKHvpobA/3NY7jxrvRma0eHPo8KfwOA/OR 1ihy2AqyXTosIHccI6EADn8+PzKFmNMpewZkCFUUi82yW5uKqNEwD5E1h0mm6l3lfcbm LRUfbcyYILmhNSijgmHhLtuBc8kqPhPgaTVBpxShdTQb+nECuMb7gXX7V8GDq14BqqDw i7XHI3dzhi6UDK+6bxa8tjKgBwjfKIsq7ftungMvcnWx/NZNAhsMTz0b7On0/buRhorq 6Ftg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=OAAK8rw+; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4si3779210edj.263.2019.11.13.19.38.54; Wed, 13 Nov 2019 19:39:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=OAAK8rw+; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726985AbfKNDiQ (ORCPT + 99 others); Wed, 13 Nov 2019 22:38:16 -0500 Received: from mail-eopbgr20056.outbound.protection.outlook.com ([40.107.2.56]:36513 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726393AbfKNDiP (ORCPT ); Wed, 13 Nov 2019 22:38:15 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8ikBk8OgwDIzWaTNBUPmqJ7Mwe0Cnvve/9zGJ8JETJ6tWfNSlRf88iI98OvdLUMr5QJyMF3f63GqiSpZkp6jdx5LYOtUBHXHhOwqvpNZDfjY7eWFGj9Pv02PtvR2UQKD3I/DFLz8PZm70wNiZxsZNDGRnjfLSlo7DttUMsAFn9aYfMvVj6QaH9o3hXBFqhkUaECPcSmUNHOeUYNFvQgkcuuLW5oTIkyGDnF5ruaiNbyxk78jSq6E3ov4n726aTBdYzXVnw0B2deRz7In/mn0B6MY6Ey/rla/ZBBKPLcDQYBzbzGxo56s0saquEMg0DAlOCVsunRukgmbcyx2hrMHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2EkBPnFwsWwCoy3O91Sga15UCfRLu1FZh+B5Qejowk=; b=GETkZtH5maXRZ+ZDZxKWQF20a3N7Zwxo6SRbP+s7jVBWCfI9U9AjphfxWGJVxZRVUorb1NjrIECeGDCXPyQIj+bU8P+RavrkUsZRh1zcxbrnVYxR1z+WV4Z6ZyKg1e4w2lBEf6EtKRjT/sCQlVoWN1gNrG/TSv9+cNDKc3dS04lrU9MrmvB6+7GryXfiFGcspiJ8tZnFbOs5JXh7g3Hh0mvtWDYS6OmvwPvPykYKfCgErzi21p1jj+uNst+rLWO+CbtzexHJ9iDC/OmD/e4sJkoTabNDDReuIZRjcuO+mfeylt1WKjg40WvQ2BkG066gm/bzVKI3CB64JvX6R7lebQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2EkBPnFwsWwCoy3O91Sga15UCfRLu1FZh+B5Qejowk=; b=OAAK8rw+dSbSVQB2j79HQQI7CtaiBFIWqcMGbNhG5Cg2O3kT2EPO00+RBFt5UGgIjVdu0u/0x3S3XA6iqTZd5d4iSn2d6vaJH5Jc2TJ3XK6pMHfKvrdtnkfXZWeOjd05ECJJqLAQ7AZjjhL+tKKJlexHIz+oYlGeKYgcxG0CYCk= Received: from AM0PR04MB4481.eurprd04.prod.outlook.com (52.135.147.15) by AM0PR04MB4994.eurprd04.prod.outlook.com (20.176.215.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.26; Thu, 14 Nov 2019 03:38:12 +0000 Received: from AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::f16d:a26a:840:f97c]) by AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::f16d:a26a:840:f97c%4]) with mapi id 15.20.2451.024; Thu, 14 Nov 2019 03:38:12 +0000 From: Peng Fan To: "sboyd@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , Abel Vesa CC: "kernel@pengutronix.de" , dl-linux-imx , Aisheng Dong , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez , Alice Guo , "will@kernel.org" , Peng Fan Subject: [PATCH V2 1/4] clk: imx: pll14xx: use writel_relaxed Thread-Topic: [PATCH V2 1/4] clk: imx: pll14xx: use writel_relaxed Thread-Index: AQHVmpzwa1AKzGFdyU6W3OlQ058WhQ== Date: Thu, 14 Nov 2019 03:38:12 +0000 Message-ID: <1573702559-2744-2-git-send-email-peng.fan@nxp.com> References: <1573702559-2744-1-git-send-email-peng.fan@nxp.com> In-Reply-To: <1573702559-2744-1-git-send-email-peng.fan@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0PR01CA0033.apcprd01.prod.exchangelabs.com (2603:1096:203:3e::21) To AM0PR04MB4481.eurprd04.prod.outlook.com (2603:10a6:208:70::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5261280d-39e0-4170-7741-08d768b41333 x-ms-traffictypediagnostic: AM0PR04MB4994:|AM0PR04MB4994: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 02213C82F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(199004)(189003)(66066001)(305945005)(14454004)(36756003)(71200400001)(71190400001)(4744005)(7736002)(2501003)(99286004)(4326008)(486006)(81156014)(81166006)(25786009)(86362001)(44832011)(2616005)(476003)(50226002)(446003)(11346002)(8676002)(8936002)(52116002)(76176011)(186003)(478600001)(6506007)(386003)(6486002)(6512007)(6436002)(2201001)(102836004)(26005)(316002)(5660300002)(54906003)(110136005)(256004)(14444005)(3846002)(6116002)(66556008)(6636002)(66446008)(66946007)(64756008)(66476007)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB4994;H:AM0PR04MB4481.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MGxCmRXuCb3qzfRPvT9XywyUAoCqFIibUuoSp7uxQ/NLq39PvaNrtkWJB1tDiUAHRj4x6/WJQDkfzeiWcmoxUZLNICjUy0YKlE0AIN6x2PcqX3OoksC7EEJ2vmOx4OWj1+YGmLOa296Hs++nAqpNLkNk+UtE1TfdEbpqdzRgGFMkqmETbYAlH52ycQcm5RoieKjTZOOUjMNz0Ndzpkh/7T5jp3krUCCKlZbg59NP89f55B5zZmxrwzCdPmFbQp9xGWrB4sgc4QCQa2QwIN4EWXQc7I01QgXclsboLdjurkYcbmMBtxxFOyWyjcyeoEAc/FAJB6gkLYJhjV6hNJliqv28P1nq74PvymQAByH7sJcJFA9CZfhpHq4bBlHEsNPcbE2CYx47x2GF+8A8siG7x7TL3XMBN8p/5U62go8Cdn6KJYZ8NEg2hysGMESRx9NA Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5261280d-39e0-4170-7741-08d768b41333 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2019 03:38:12.5734 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aug73e5oa+2yFhkQBDj6vi54aYLE2Ctp+sau1vkPE+o6irnQhgiYuM5dgJQ2kNByclcNDlZLLgAZjpRtMkn92Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4994 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Fan writel has a barrier, however that barrier is not needed, because device memory mapping is nGnRE mapping and access is in order and clk driver has spin lock or other lock to make sure write finished. Cc: Will Deacon Signed-off-by: Peng Fan --- drivers/clk/imx/clk-pll14xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index 5778f3bfb339..5b7d41d43b3b 100644 --- a/drivers/clk/imx/clk-pll14xx.c +++ b/drivers/clk/imx/clk-pll14xx.c @@ -199,7 +199,7 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, uns= igned long drate, =20 /* Enable BYPASS */ tmp |=3D BYPASS_MASK; - writel(tmp, pll->base); + writel_relaxed(tmp, pll->base); =20 div_val =3D (rate->mdiv << MDIV_SHIFT) | (rate->pdiv << PDIV_SHIFT) | (rate->sdiv << SDIV_SHIFT); --=20 2.16.4