Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Manish Rangankar <mrangankar@marvell.com>
To:     Pan Bian <bianpan2016@163.com>,
        "QLogic-Storage-Upstream@qlogic.com" 
        <QLogic-Storage-Upstream@qlogic.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] SCSI: qla4xxx: fix double free bug
Thread-Topic: [PATCH] SCSI: qla4xxx: fix double free bug
Thread-Index: AQHVk704LzvZr/hpFk+MexrJVSr6K6eKJC9Q
Date:   Thu, 14 Nov 2019 04:42:33 +0000
Message-ID: <MN2PR18MB302207CEA407EB6C5E8C2A05D8710@MN2PR18MB3022.namprd18.prod.outlook.com>
References: <1572945927-27796-1-git-send-email-bianpan2016@163.com>
In-Reply-To: <1572945927-27796-1-git-send-email-bianpan2016@163.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e1001c0-d25f-491b-3318-08d768bd10b5
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2019 04:42:33.3683
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L6MmX6uk3dbwCZYt2K2evuaZON3iXxQcz9onjhiR8vHEIsPpzZV7bDZJtRTsqBSn/BYRKzQFUYgwdMflYPRuSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2384
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572
 definitions=2019-11-13_06:2019-11-13,2019-11-13 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org <linux-scsi-
> owner@vger.kernel.org> On Behalf Of Pan Bian
> Sent: Tuesday, November 5, 2019 2:55 PM
> To: QLogic-Storage-Upstream@qlogic.com; James E.J. Bottomley
> <jejb@linux.ibm.com>; Martin K. Petersen <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Pan Bian
> <bianpan2016@163.com>
> Subject: [PATCH] SCSI: qla4xxx: fix double free bug
>=20
> The variable init_fw_cb is released twice, resulting in a double free bug=
. The
> call to the function dma_free_coherent() before goto is removed to get ri=
d
> of potential double free.
>=20
> Fixes: 2a49a78ed3c ("[SCSI] qla4xxx: added IPv6 support.")
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
>  drivers/scsi/qla4xxx/ql4_mbx.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mb=
x.c
> index dac9a7013208..02636b4785c5 100644
> --- a/drivers/scsi/qla4xxx/ql4_mbx.c
> +++ b/drivers/scsi/qla4xxx/ql4_mbx.c
> @@ -640,9 +640,6 @@ int qla4xxx_initialize_fw_cb(struct scsi_qla_host *
> ha)
>=20
>  	if (qla4xxx_get_ifcb(ha, &mbox_cmd[0], &mbox_sts[0],
> init_fw_cb_dma) !=3D
>  	    QLA_SUCCESS) {
> -		dma_free_coherent(&ha->pdev->dev,
> -				  sizeof(struct addr_ctrl_blk),
> -				  init_fw_cb, init_fw_cb_dma);
>  		goto exit_init_fw_cb;
>  	}

Thanks

Acked-by: Manish Rangankar <mrangankar@marvell.com>