Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2885227ybc; Thu, 14 Nov 2019 00:10:39 -0800 (PST) X-Google-Smtp-Source: APXvYqxBAX10z7feJ6efzbF84znn9izeii6r51YcpqucTCRabTloRKOdVdeV6Oy60wqCu+vPGoXI X-Received: by 2002:a50:c305:: with SMTP id a5mr8255520edb.136.1573719039622; Thu, 14 Nov 2019 00:10:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573719039; cv=none; d=google.com; s=arc-20160816; b=PX0g0w/J9C2imyB4EpLe39PiTAAHoZ4vOpgUPUzO0CzjP3g3fjS3ljnRPzs0HGFZtg chxcJsuWYYwcWsqBecVmNMFZW8KGVx1zPKTL76r+R7JC21zelIUqZJ8Hc3aCEf9gyIfm HMKOp+g5BTgeFVkcYyOBCeD+6CGWM0iGGyCmDrbhIyLj89vizdd/Xll6dYWnLG3zVhgb lRBmwCZwZpJ1bAtgK5fJNzCGDJ/Q2bZzaAmE/il3tEAs2vAOJz5KDP6HMUlHoV6mO/32 aKFFSyjTX1T9FpFIn9Xx9MylrOqCU2UiPAFxSkpu6eT4MdYLsOOV89f3PFUVmjO1EsOc Uv/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=OsKr4ORBaTvFR9O6y3bdIsPWpFGX9JeRN+2c/4AcBbE=; b=y7D2JJFZPoTvz7VjWqBmt8zayHdPl0vH6e+8cuJXQNJCvb9jS62ua6iQnn6+DrErhi pd0Ccp0CKmnjtPGz7rr17h+Hst0zsXb5eQXhBSr5ElHKA5/7nvnZ9ttg26fpd2R1F+QJ gjpreW3R7BP1aQthoG5efs9hsHCUmN4RGq5zJINVrFJAhI7h2NvP2x5OVb6yebuk3AdS yIKlw1yMSgh1Z6w5hNCNq8ojwpDCJDcCQHaW1hdzfhzWyJx4Kp/lDor8PbmVbS52ZU9o pmwoyhm7IwvENcxU9hLVAnJPLpIkCgwU3v431cqWsd8OVYmAxCUEr1reEGXcCirTH6Tx 0VeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h26si3498176edb.303.2019.11.14.00.10.14; Thu, 14 Nov 2019 00:10:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726444AbfKNIJ2 (ORCPT + 99 others); Thu, 14 Nov 2019 03:09:28 -0500 Received: from thoth.sbs.de ([192.35.17.2]:37567 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfKNIJ1 (ORCPT ); Thu, 14 Nov 2019 03:09:27 -0500 Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id xAE89CZT030781 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Nov 2019 09:09:13 +0100 Received: from [167.87.46.11] ([167.87.46.11]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xAE89CH4016661; Thu, 14 Nov 2019 09:09:12 +0100 Subject: Re: [FYI PATCH 0/7] Mitigation for CVE-2018-12207 To: Dave Hansen , Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Ralf Ramsauer , "Gupta, Pawan Kumar" References: <1573593697-25061-1-git-send-email-pbonzini@redhat.com> <23353382-53ea-8b20-7e30-763ef6df374c@siemens.com> From: Jan Kiszka Message-ID: Date: Thu, 14 Nov 2019 09:09:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.11.19 22:24, Dave Hansen wrote: > On 11/13/19 12:23 AM, Paolo Bonzini wrote: >> On 13/11/19 07:38, Jan Kiszka wrote: >>> When reading MCE, error code 0150h, ie. SRAR, I was wondering if that >>> couldn't simply be handled by the host. But I suppose the symptom of >>> that erratum is not "just" regular recoverable MCE, rather >>> sometimes/always an unrecoverable CPU state, despite the error code, right? >> The erratum documentation talks explicitly about hanging the system, but >> it's not clear if it's just a result of the OS mishandling the MCE, or >> something worse. So I don't know. :( Pawan, do you? > > It's "something worse". > > I built a kernel module reproducer for this a long time ago. The > symptom I observed was the whole system hanging hard, requiring me to go > hit the power button. The MCE software machinery was not involved at > all from what I could tell. Thanks for clarifying this - too bad. > > About creating a unit test, I'd be personally happy to share my > reproducer, but I built it before this issue was root-caused. There are > actually quite a few underlying variants and a good unit test would make > sure to exercise all of them. My reproducer probably only exercised a > single case. > Would be interesting to see this. Ralf and tried something quickly, but there seems to be a detail missing or wrong. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux