Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Nov 2019 09:22:09 +0100
From:   Adrian Reber <areber@redhat.com>
To:     Christian Brauner <christian.brauner@ubuntu.com>
Cc:     Eric Biederman <ebiederm@xmission.com>,
        Pavel Emelyanov <ovzxemul@gmail.com>,
        Jann Horn <jannh@google.com>, Oleg Nesterov <oleg@redhat.com>,
        Dmitry Safonov <0x7f454c46@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        linux-kernel@vger.kernel.org, Andrei Vagin <avagin@gmail.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Radostin Stoyanov <rstoyanov1@gmail.com>
Subject: Re: [PATCH v9 1/2] fork: extend clone3() to support setting a PID
Message-ID: <20191114082209.GE1252861@dcbz.redhat.com>
References: <20191114070709.1504202-1-areber@redhat.com>
 <20191114081359.axnoioa25grf3ffv@wittgenstein>
MIME-Version: 1.0
In-Reply-To: <20191114081359.axnoioa25grf3ffv@wittgenstein>
Organization: Red Hat
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 14, 2019 at 09:14:00AM +0100, Christian Brauner wrote:
> On Thu, Nov 14, 2019 at 08:07:08AM +0100, Adrian Reber wrote:
> >   * The structure is versioned by size and thus extensible.
> >   * New struct members must go at the end of the struct and
> > @@ -71,6 +85,8 @@ struct clone_args {
> >  =09__aligned_u64 stack;
> >  =09__aligned_u64 stack_size;
> >  =09__aligned_u64 tls;
> > +=09__aligned_u64 set_tid;
> > +=09__aligned_u64 set_tid_size;
>=20
> Oh, one thing that is missing is the addition of
>=20
> +#define CLONE_ARGS_SIZE_VER1 80 /* sizeof second published struct */
>=20
> in sched.h. Please add that, when you resend.

Even if it is unused?

=09=09Adrian