Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 97pRY4qKgCbI1m7AjL66TEzIPR6RnIaMc4KnQkX+NAHKslzuhT10TXT5by3IRIGS53y/IWT3IA
 WTuFIG4emAUskbz0FKxoa47yTjhpKTBr3JTBNPiIfi8FLkrf4deJ6ga6fhHXKbyGPB3DN5rkOZ
 YpRbAJax2ivFhy82kfVYwFOV5d7HqAWdAyxT538IsFWRAAhNir0mjCiUnCVn8oX3CIBl5pB2ed
 6mmWb930BIDdVb6+sTa+rJD/whhqy8j+Uu8SlyeC0+au3g6nB1PW2pIs51qtW/yVhfcawONZ6m
 YSo=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "rnayak@codeaurora.org" <rnayak@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "saravanak@google.com" <saravanak@google.com>,
        "salyzyn@google.com" <salyzyn@google.com>
CC:     Andy Gross <agross@kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Pedro Sousa <pedrom.sousa@synopsys.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 2/7] scsi: ufs-qcom: Add reset control support for host
 controller
Thread-Topic: [PATCH v4 2/7] scsi: ufs-qcom: Add reset control support for
 host controller
Thread-Index: AQHVme4abyNW2mq0C0+96JxTUVeHeaeKX+vA
Date:   Thu, 14 Nov 2019 09:03:13 +0000
Message-ID: <MN2PR04MB69918A580EC558ECF3FB2748FC710@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <1573627552-12615-1-git-send-email-cang@codeaurora.org>
 <1573627552-12615-3-git-send-email-cang@codeaurora.org>
In-Reply-To: <1573627552-12615-3-git-send-email-cang@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 65f9a2fc-af30-4b61-b92e-08d768e17afd
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2019 09:03:13.5278
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XcBJs8IkamHnYiOZLNwLnWhnjff0P4JsdN63AVcKfDVfM441ghZIU6HbeRpGgaS+5f9I/gfnyWRAX856vUzhnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7102
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

>=20
>=20
> Add reset control for host controller so that host controller can be rese=
t as
> required in its power up sequence.
>=20
> Signed-off-by: Can Guo <cang@codeaurora.org>
> +       ret =3D reset_control_assert(host->core_reset);
> +       if (ret) {
> +               dev_err(hba->dev, "%s: core_reset assert failed, err =3D =
%d\n",
> +                                __func__, ret);
> +               goto out;
> +       }
> +
> +       /*
> +        * The hardware requirement for delay between assert/deassert
> +        * is at least 3-4 sleep clock (32.7KHz) cycles, which comes to
> +        * ~125us (4/32768). To be on the safe side add 200us delay.
> +        */
> +       usleep_range(200, 210);
Aren't you sleeping anyway in your reset_control_ops?

> +
> +       ret =3D reset_control_deassert(host->core_reset);
> +       if (ret)
> +               dev_err(hba->dev, "%s: core_reset deassert failed, err =
=3D %d\n",
> +                                __func__, ret);
> +
> +       usleep_range(1000, 1100);
ditto