Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-12-arnd@arndb.de>
 <alpine.DEB.2.21.1911132306070.2507@nanos.tec.linutronix.de> <20191113210611.515868a4@oasis.local.home>
In-Reply-To: <20191113210611.515868a4@oasis.local.home>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Thu, 14 Nov 2019 11:52:38 +0100
Message-ID: <CAK8P3a17qGymdM6JZYYB_o7hazVDNAB129duSoYtyNoBz1rnSg@mail.gmail.com>
Subject: Re: [PATCH 21/23] y2038: itimer: change implementation to timespec64
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        y2038 Mailman List <y2038@lists.linaro.org>,
        Ingo Molnar <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>,
        Frederic Weisbecker <frederic@kernel.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 14, 2019 at 3:06 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 13 Nov 2019 23:28:47 +0100 (CET) Thomas Gleixner <tglx@linutronix.de> wrote:
> > > -           __entry->value_usec     = value->it_value.tv_usec;
> > > +           __entry->value_usec     = value->it_value.tv_nsec / NSEC_PER_USEC;
> > >             __entry->interval_sec   = value->it_interval.tv_sec;
> > > -           __entry->interval_usec  = value->it_interval.tv_usec;
> > > +           __entry->interval_usec  = value->it_interval.tv_nsec / NSEC_PER_USEC;
> >
> > Hmm, having a division in a tracepoint is clearly suboptimal.
>
> Right, we should move the division into the TP_printk()
>
>                 __entry->interval_nsec = alue->it_interval.tv_nsec;
>

Ok, fixed now, thanks for the suggestion!

     Arnd