Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3031248ybc; Thu, 14 Nov 2019 02:58:40 -0800 (PST) X-Google-Smtp-Source: APXvYqznL+fYjvH6vTgGzC99HpmXsryZ3D6WeFHag/EGLxd8TlZ2406qDytBo4GRrd95jIAId8ha X-Received: by 2002:a17:906:a28d:: with SMTP id i13mr7557909ejz.288.1573729120700; Thu, 14 Nov 2019 02:58:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573729120; cv=none; d=google.com; s=arc-20160816; b=XrKIznvfFy07BalG+G7UmnejoHVJSaD9zZ65uBliSupOQ7V9ICqyz/QdvOSlNQctvg Ea/MZnkVBsDEd0mWDYggrBP4Q0LVJ7DDpOTfgDQ3bpN+7TFMOKlnMp7zbZWmR4e8R0Wl 5D0qZ9j7dc4TEWYLeMcz+QEYKX+0gfobNwBxPoIZRKNNMUDr0nLDi1Bknyx+1B6h+9Vv CUPSEdFYwkqRGhJxA86RTBCQ/zhl1Hr5HIbR4R9aefL4N4RcLOLFYxfGiwtjjUFUvW3l 7Tb0QUBnypa2QO6eDCGU6bWKDDHrz+jas1uuq0JOqIVCiL3btmqpKiXHH3s2GvuBhwkv nRKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=t8ZjnVD/9fMeKNmCTix7DQa3FVq72nxsDyXNvl5lJnQ=; b=Rh5LJUwLp6lPG2ea3vbPBHUAdfjFKzS8SZgEpx8RBkkZUf4uBJoko37fRfX66RBlFo 8PaBoQHbvI+rVUKdI4/f6DkF6VHdkF7lhDZUUw3tm5+uMr3Ayme0YK9TpTJqYU+FfGst BagsOle44GepICekcRwbJUEkdb7j8uNcC0e90Uexf9fjO55ceLYgexT9H8XrnpoGjDKS jywI8nF9CakcwL1rId0VUtWA7af9+5ZzL6H0zraunoD1ijegDnB0kCv7XqEwE8JXmYCe 1EE9uHKAuZshk7Ch5WWKrTqsUSozC3Jkmle58vYxPsDQoajbw/+TNvoVRG43mtInQlwN 3e+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q30si3897420edb.372.2019.11.14.02.58.15; Thu, 14 Nov 2019 02:58:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbfKNK5L (ORCPT + 99 others); Thu, 14 Nov 2019 05:57:11 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:40297 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfKNK5L (ORCPT ); Thu, 14 Nov 2019 05:57:11 -0500 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iVCoC-0008OC-T1; Thu, 14 Nov 2019 11:57:04 +0100 Date: Thu, 14 Nov 2019 11:57:04 +0100 (CET) From: Thomas Gleixner To: Arnd Bergmann cc: y2038 Mailman List , Steven Rostedt , Ingo Molnar , "linux-kernel@vger.kernel.org" , Anna-Maria Gleixner , Frederic Weisbecker , "Peter Zijlstra (Intel)" , Kees Cook Subject: Re: [PATCH 21/23] y2038: itimer: change implementation to timespec64 In-Reply-To: Message-ID: References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-12-arnd@arndb.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Nov 2019, Arnd Bergmann wrote: > On Wed, Nov 13, 2019 at 11:28 PM Thomas Gleixner wrote: > > On Fri, 8 Nov 2019, Arnd Bergmann wrote: > > > @@ -197,19 +207,13 @@ static void set_cpu_itimer(struct task_struct *tsk, unsigned int clock_id, > > > #define timeval_valid(t) \ > > > (((t)->tv_sec >= 0) && (((unsigned long) (t)->tv_usec) < USEC_PER_SEC)) > > > > Hrm, why do we have yet another incarnation of timeval_valid()? > > No idea, you have to ask the author of commit 7d99b7d634d8 ("[PATCH] > Validate and > sanitze itimer timeval from userspace") ;-) I don't know that guy. :) > > Can we please have only one (the inline version)? > > I'm removing the inline version in a later patch along with most of the rest of > include/linux/time32.h. > > Having the macro version is convenient for this patch, since I'm using it > on two different structures (itimerval/__kernel_old_timeval and > old_itimerval32/old_timeval32), neither of which is the type used in the > inline function. Fair enough. Thanks, tglx