Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v16 04/19] leds: multicolor: Introduce a multicolor class
 definition
To:     Martin Fuzzey <martin.fuzzey@flowbird.group>,
        <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
CC:     <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20191104123707.31930-1-dmurphy@ti.com>
 <20191104123707.31930-5-dmurphy@ti.com>
 <a7f18f3b-c1fb-3810-8d9b-30ecdada96ff@flowbird.group>
From:   Dan Murphy <dmurphy@ti.com>
Message-ID: <f4c891b6-3ce7-c3d7-447a-7633b96face1@ti.com>
Date:   Thu, 14 Nov 2019 06:56:23 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <a7f18f3b-c1fb-3810-8d9b-30ecdada96ff@flowbird.group>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Martin

On 11/14/19 5:24 AM, Martin Fuzzey wrote:
> Hi Dan,
>
> On 04/11/2019 13:36, Dan Murphy wrote:
>> +int devm_led_classdev_multicolor_register_ext(struct device *parent,
>> +                         struct led_classdev_mc *mcled_cdev,
>> +                          struct led_init_data *init_data)
>> +{
>> +    struct led_classdev_mc **dr;
>> +    int ret;
>> +
>> +    dr = devres_alloc(devm_led_classdev_multicolor_release,
>> +              sizeof(*dr), GFP_KERNEL);
>> +    if (!dr)
>> +        return -ENOMEM;
>> +
>> +    ret = led_classdev_multicolor_register(parent, mcled_cdev);
>
>
> This drops init_data, should be led_classdev_multicolor_register_ex
>
Thanks for the issue I will fix and send v17

Dan