Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/3 v9] kexec: Fix i386 build warnings that missed
 declaration of struct kimage
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, bhe@redhat.com, dyoung@redhat.com,
        jgross@suse.com, dhowells@redhat.com, Thomas.Lendacky@amd.com,
        ebiederm@xmission.com, vgoyal@redhat.com, d.hatayama@fujitsu.com,
        horms@verge.net.au, kexec@lists.infradead.org
References: <20191108090027.11082-1-lijiang@redhat.com>
 <20191108090027.11082-4-lijiang@redhat.com> <20191114123920.GA7222@zn.tnic>
From:   lijiang <lijiang@redhat.com>
Message-ID: <59fbd119-495a-4d00-9738-98c22b276c1f@redhat.com>
Date:   Thu, 14 Nov 2019 22:20:42 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20191114123920.GA7222@zn.tnic>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=E5=9C=A8 2019=E5=B9=B411=E6=9C=8814=E6=97=A5 20:39, Borislav Petkov =E5=86=
=99=E9=81=93:
> On Fri, Nov 08, 2019 at 05:00:27PM +0800, Lianbo Jiang wrote:
>> Kbuild test robot reported some build warnings as follow:
>>
>> arch/x86/include/asm/crash.h:5:32: warning: 'struct kimage' declared
>> inside parameter list will not be visible outside of this definition
>> or declaration
>>     int crash_load_segments(struct kimage *image);
>>                                    ^~~~~~
>>     int crash_copy_backup_region(struct kimage *image);
>>                                         ^~~~~~
>>     int crash_setup_memmap_entries(struct kimage *image,
>>                                           ^~~~~~
>> The 'struct kimage' is defined in the header file include/linux/kexec.h,
>> before using it, need to include its header file or make a declaration.
>> Otherwise the above warnings may be triggered.
>>
>> Add a declaration of struct kimage to the file arch/x86/include/asm/
>> crash.h, that will solve these compile warnings.
>>
>> Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system=
 call")
>=20
> This is, of course, wrong. Your *first* patch is introducing those
> warnings and I'm wondering how did you not see them during building?
>=20

I really saw my building result, but kbuild reported the following messages=
:

vim +5 arch/x86/include/asm/crash.h

dd5f726076cc76 Vivek Goyal 2014-08-08   4 =20
dd5f726076cc76 Vivek Goyal 2014-08-08  @5  int crash_load_segments(struct k=
image *image);
dd5f726076cc76 Vivek Goyal 2014-08-08   6  int crash_copy_backup_region(str=
uct kimage *image);
dd5f726076cc76 Vivek Goyal 2014-08-08   7  int crash_setup_memmap_entries(s=
truct kimage *image,
dd5f726076cc76 Vivek Goyal 2014-08-08   8  =09=09struct boot_params *params=
);
89f579ce99f7e0 Yi Wang     2018-11-22   9  void crash_smp_send_stop(void);
dd5f726076cc76 Vivek Goyal 2014-08-08  10 =20

:::::: The code at line 5 was first introduced by commit=20
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
:::::: dd5f726076cc7639d9713b334c8c133f77c6757a kexec: support for kexec on=
 panic using new system call
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^=
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Would you mind giving me any suggestions about this?

> In file included from arch/x86/realmode/init.c:11:
> ./arch/x86/include/asm/crash.h:5:32: warning: =E2=80=98struct kimage=E2=
=80=99 declared inside parameter list will not be visible outside of this d=
efinition or declaration
>     5 | int crash_load_segments(struct kimage *image);
>       |                                ^~~~~~
> ./arch/x86/include/asm/crash.h:6:37: warning: =E2=80=98struct kimage=E2=
=80=99 declared inside parameter list will not be visible outside of this d=
efinition or declaration
>     6 | int crash_copy_backup_region(struct kimage *image);
>       |                                     ^~~~~~
> ./arch/x86/include/asm/crash.h:7:39: warning: =E2=80=98struct kimage=E2=
=80=99 declared inside parameter list will not be visible outside of this d=
efinition or declaration
>     7 | int crash_setup_memmap_entries(struct kimage *image,
>       |
>=20
>=20
> And that happens because you've included asm/crash.h in
> arch/x86/realmode/init.c and it of course complains because it hasn't
> seen that struct yet.
>=20

Exactly. Last time, i fixed the warnings in my first patch, please refer to=
 the patch v8(resend).

Link: https://lkml.kernel.org/r/20191031033517.11282-2-lijiang@redhat.com
      -[PATCH 1/2 RESEND v8] x86/kdump: always reserve the low 1M when the =
crashkernel option is specified


And kbuild said that need to add the reported-by, please refer to the follo=
wing Link.

Link: https://lkml.kernel.org/r/201910310233.EJRtTMWP%25lkp@intel.com

> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>

Any idea about this? Any suggestions will be appreciated.

Thanks.
Lianbo