Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3270071ybc; Thu, 14 Nov 2019 06:39:13 -0800 (PST) X-Google-Smtp-Source: APXvYqxZqEyCmeFWDQhkSSNt7PaPdV8C7ugF32HaKj/CmX6XYqfV8/u6dCIziBYvAzQHDUXy8UXF X-Received: by 2002:a50:fc18:: with SMTP id i24mr1616110edr.41.1573742353220; Thu, 14 Nov 2019 06:39:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573742353; cv=none; d=google.com; s=arc-20160816; b=y3JTvq6kJ2Ytj2zywsfzq+giQow29d5edcOWyCjgH66aFV3AVgE7Zvvx0RVUO221TT wZg7W/Lw1ZTMDkXsXY7LDqbGvbWhQGoFsdfekc8Cgqzh7hnEzsAmNQ7CNqn//arw9onM b8M59EqnBBK9FZmUTheTy8nWvMlAlYsNJF2cwQOnUam+xirOLQ1xbfZ5GM9tEJkJnyWR SR5+HyXLShElH2dgg6bukMwCblMiBfCT3lnr4Ok//rpumJTavR7AiWAc/71xcp55w6Tc zwwHTPTNO8FxfQlNMtx9LOoiSMsjahgQ1TbF8NIjc8lYu1ukfinTonNzIbLej+DMy+jX N5XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=Mbx+0taDVAMiOSvl1PE/qUNRG6ghGyz/9ddFUz9BgXk=; b=BmUaXF3S8vi7BGJtjAOcvpsXCkRslJDCBxdcTJrR6kLGu8UqYIgHgQV8NlBtSgryIh iz99zY/n7kyZOO3dRVaMc1KN/mjDEKF3AlQ2U+8qwVuKZEJagk5Nd/0Y3MpKoAC0pa8O wrvCBYLUkqRJGIwcdQyZKfwdR+jnlcFhrrvkh4X+NFp2DabfLMQaBLuGqBn2mzuK/LSY XXbj68zT6K3kN9C6OKV9O+fKzOgtrodx69oHvpacVGlsH6RTLpD9QlFZHMkQU2IOmePd WyW/O+gwX41ld/i5oa2KYvs+z46kPQWb4ddocM8SW97aDuFLY0wCG72y+No5/i4P6Q0w uk5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y18si3710270eju.279.2019.11.14.06.38.48; Thu, 14 Nov 2019 06:39:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726838AbfKNOf4 (ORCPT + 99 others); Thu, 14 Nov 2019 09:35:56 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:51003 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbfKNOfz (ORCPT ); Thu, 14 Nov 2019 09:35:55 -0500 Received: from mail-qv1-f47.google.com ([209.85.219.47]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MUooJ-1iM5H61Mw5-00QnXD; Thu, 14 Nov 2019 15:35:53 +0100 Received: by mail-qv1-f47.google.com with SMTP id i3so2409652qvv.7; Thu, 14 Nov 2019 06:35:53 -0800 (PST) X-Gm-Message-State: APjAAAX+3GU8M9fqYdTDoiy79ddpna94vkO4v+4uwR8vRos/yu7VMVRi 1xejSJoknQpHSEb+vHMrxZUzMQXEIy70XQVUGOU= X-Received: by 2002:a0c:a9cc:: with SMTP id c12mr8417384qvb.222.1573742152140; Thu, 14 Nov 2019 06:35:52 -0800 (PST) MIME-Version: 1.0 References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-8-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Thu, 14 Nov 2019 15:35:35 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 17/23] y2038: time: avoid timespec usage in settimeofday() To: Thomas Gleixner Cc: y2038 Mailman List , John Stultz , "linux-kernel@vger.kernel.org" , Stephen Boyd , David Howells , Al Viro , Deepa Dinamani , Christian Brauner , Jens Axboe , Ingo Molnar , Corey Minyard , zhengbin , Li RongQing , Linux API Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:vTkO2UihZATd4ascmfM7HonFINA46Gzd02p6oqajIizANs0ziaL KtqO4Tr5vyNzSsO1CL/z8dQ1ub0D/ueSJN/XEBD9OEyoW6UdcVp1TOwWVAfSZMHULDvJ4y2 t5wXcHsW3YfPES8YAdelta7112ZaW3sP5sSdKAtV49CpJIwhlbYWBsRkZ1uWJO6JTuxvBqE ZIjezZoOMguSfJcCzF8bw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XTYDQS696YA=:gcAS4B6hlhDgUrklpBe86A D3lF/rocGAFmA4bDcRbxZx0u9hJ2osrQFbt1xvySBTcDYBzwR33KyVugER2DQs6WzvlI+6OER 9lF0x+Vxx7whyxhie5ia/abKfzK5ZUMrwiiaFYQX8dp85q/Axxkylku7L+UuWxwvjbQStV+n1 VTaEUZe5tBPFHv3h/vKDMGzaIrnW5c4L/YT+XN1Qr59r66iTr/H+PURV6ANzCYm8JSmEotAXF EBhqNtDZDhdXVRWe40XtmgsE+36O3ao9Z4FDGv2v5wOAkJ128eb4zJXVD8Tn7pLicjc2SqINH Fyobq/djuaeKbxqOqTaVLY2mMDyIXHZ8c4tykmmhjfJyeHneqE4vNSE5/TZl+pbZ0P6FNpTqt VQVJ0TccDgH3TsQCa7nArwqpJqEvBullHlooj6dX9LUGgSA1gB4ioS69BOAcmdwwAtf5BeLDe RCSRqFDITAit1AwZ54fAp1g9kZRD25yVe0Sak4JJ/yTR4qpi7uHkfIMUo4glStQI1wPXdzxcb goDWOEfu9zAaufZMMS6boTjYE2HdXSWcaUA/k9F/JUU9HepYWCF1y4/1OHuTBfCsO02iHuKO7 wxodFE4Z5Ktt/xS7brl0gIzXcp6IKEkRUtKWZxGSH+4Tscv6vhKuYYZDcGGMg+QjwAPQpMlpB 5SEVfvXqXJ027xJXW3LMBv20hWpr3ZJqrSbPZnnupn5nYPPI05n9mbUcnIwBm9aPzEaZXlTfc ok6cBVgzfiLRHL8e1vPwvSFkkZogMi7JcSCat74dBcBAz7B5BRy9lALZ1AOcT8yudT54bOn71 L19dPz2qY0WSN9oYE1kG0ARcAtBSvTHG7STEbv4iLZPIOo3WYY1dl5cMsKtpeZei6EqImz1ft 9PCTjFdZRm9uByH2p2TA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 14, 2019 at 3:04 PM Thomas Gleixner wrote: > On Thu, 14 Nov 2019, Arnd Bergmann wrote: > > On Wed, Nov 13, 2019 at 10:53 PM Thomas Gleixner wrote: > > > > My idea was to not duplicate the range check that is done > > in do_sys_settimeofday64() and again in do_settimeofday64: > > > > if (!timespec64_valid_settod(ts)) > > return -EINVAL; > > > > The only check we should need in addition to this is to ensure > > that passing an invalid tv_usec number doesn't become an > > unexpectedly valid tv_nsec after the multiplication. > > Right, but please add a proper comment as you/we are going to scratch heads > 4 weeks from now when staring at that check and wondering why it is > incomplete. Ok, done. I had just uploaded the branch with the fixup for the __user pointer access in the same patch, but that version had introduced another typo. I hope the version I uploaded now has all known issues addressed for tomorrow's linux-next. Arnd