Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3354624ybc; Thu, 14 Nov 2019 07:54:38 -0800 (PST) X-Google-Smtp-Source: APXvYqxBCrHOphuCBAqR5Zw1QaIGZwPzWqzWuMVFexSb2Nfk4B960L2uG+kyFZ9SJTgpKDto4nXw X-Received: by 2002:aa7:d554:: with SMTP id u20mr2049784edr.6.1573746878353; Thu, 14 Nov 2019 07:54:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573746878; cv=none; d=google.com; s=arc-20160816; b=Fp2wlw+0qJUo7KXF+wx/w0hsNZnkVe3KkCE7icQQvzEdO3PxtEKFExDYTU44wLbolh AvB80pRJNzrmavbpaTCaOz6/cfLTKWLtFV80mR+HR5zKaRvVEHGbmuDimmVMLoRlWaVK msJ9P31V4IwOmowxEM9r3ldEGtkttbZUuEOEMCg29y5LvdxPmcP+Mxs3DLDpFfO7EgA4 i3Bht1cOh/jhTCmiq/XtZAZK8Ybvzp+8Lpg2vAhalMbFBnXW8osNtY8iay/JRq5p7NDP gPqrlltukmpMEc0VIthyRNAJA3yuevUgEiBHUvUmSJTtXvOSJUxEombbHrprGBSZjXD7 zDew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tLI/gn4OSN8ZC/Du6JdVBQfUYGGcPQMSiqf5vI2eXOc=; b=bqc05Oidn5tkXdLv6VSBnqYRbQ0HWnBJhTYeSkl8ZNvg6KGR/HYdufeEORlrJKtDRh rtPPHKbYkwAaESVL+eAdPjkH6eELeSIEUQR/am91Qj67F4f0y5HkEA/RLgR7/qwFjztw 27c0qHftlNPNIQ/SvvGr9u9SG9TXdzOaShBhpe/FaF+nhI2CA1exrfB3azUxl6oZMbFm niyodAa7HcGZqlkgF2wjEF5lgoUerJIYXlClnAQJCcHpCRkOlGsg3mJiEMw78y9xR62M XxyNBX9gI5LnhZXQ7nU6K8NNqrVkZ4FcoJRZxlMOvz04LineFSFZ8G+N0K7aTKt/KdTl Eurg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=Dd727wo+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si4527447edc.195.2019.11.14.07.54.12; Thu, 14 Nov 2019 07:54:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=Dd727wo+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbfKNPxG (ORCPT + 99 others); Thu, 14 Nov 2019 10:53:06 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:42473 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbfKNPxG (ORCPT ); Thu, 14 Nov 2019 10:53:06 -0500 Received: by mail-qt1-f196.google.com with SMTP id t20so7272032qtn.9 for ; Thu, 14 Nov 2019 07:53:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tLI/gn4OSN8ZC/Du6JdVBQfUYGGcPQMSiqf5vI2eXOc=; b=Dd727wo+TuDWwkH44X9N4CtBsI2dSYsENPDZa58bkPuAqqYfbwYj2r1Nk4lJhLwMtg gAP8Zjtdv9AocJu8SGIIAQWMmAaG0WTWZF0Y1Qv9/RVMvHUs0aQFrpLlMUHJEkgMsFR4 pEhnfS8bWWut7Rk/dDx/YCO9wkwnFvFMvjy25+Teb+aMd3Mgvzq7GrSoEn1X//aptASa zBHNyZgY8wk7d/1Pq10HA0IMPg9JSqbJprel0jFNaNMN0o8V+j90xs9jxJQyQ2+jmQr6 5zUGXxNmfIWt2387u/W9iGxHAS0orB8bAju6IPR7SmHo77BE24FPTiGhX0fOlhrcn5S9 uS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tLI/gn4OSN8ZC/Du6JdVBQfUYGGcPQMSiqf5vI2eXOc=; b=r3Vda8/Fln2nOrgd47cqKGjeN48Vd8JUCTFoAv2uufpfOo8oBnFLMpjKpv/pqbUzLa O+GXsjq9De4kDtUAD4ZA6VBfS6mA30IPgAwI+vcTnYD+ZuaI8eLxh7BvtLENCzsikFT/ bFAE728BjFonfhIHd6R8LJ6uMi4pO/bgksmj9HL4/ZhwuF9+6DQuGwxnrxh7vqf6/pMQ nRCqA8cFwYjZrxyJYdLAmWRG/Ej0IC91NFwuWVNK+41XG6IIeeTc97u1+7HJ1zWBlSeF MfqJM874bQR5OSn0AM9JmLKtieNuaorAaIljmPwL6dNadvMZQ6owxB/ACvplHxv2eYbC D+lA== X-Gm-Message-State: APjAAAUo38wZiB91gMqVlPvngkGuBFyf8J5q7BtZ+Wn0F6L+BoimGKUy 4S5qlkaNTWL4Xa11DvGGB3kkqg== X-Received: by 2002:ac8:1494:: with SMTP id l20mr8747839qtj.356.1573746785170; Thu, 14 Nov 2019 07:53:05 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id c27sm2592467qko.132.2019.11.14.07.53.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Nov 2019 07:53:04 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iVHQd-0007Yv-Cq; Thu, 14 Nov 2019 11:53:03 -0400 Date: Thu, 14 Nov 2019 11:53:03 -0400 From: Jason Gunthorpe To: Pan Bian Cc: Michal Kalderon , Ariel Elior , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RDMA/qedr: fix potential use after free Message-ID: <20191114155303.GA29040@ziepe.ca> References: <1573021434-18768-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573021434-18768-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2019 at 02:23:54PM +0800, Pan Bian wrote: > Move the release operation after error log to avoid possible use after > free. > > Signed-off-by: Pan Bian > --- > drivers/infiniband/hw/qedr/qedr_iw_cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason