Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Omer Shpigelman <oshpigelman@habana.ai>
To:     "oded.gabbay@gmail.com" <oded.gabbay@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/8] habanalabs: prevent read/write from/to the device during
 hard reset
Thread-Topic: [PATCH 4/8] habanalabs: prevent read/write from/to the device
 during hard reset
Thread-Index: AQHVmxita4K3BTtxlkKDNafyiadmvQ==
Date:   Thu, 14 Nov 2019 18:23:56 +0000
Message-ID: <20191114182346.22675-4-oshpigelman@habana.ai>
References: <20191114182346.22675-1-oshpigelman@habana.ai>
In-Reply-To: <20191114182346.22675-1-oshpigelman@habana.ai>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 2.17.1
x-originating-ip: [31.154.190.6]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c682d378-6d64-4b34-24c4-08d7692fcf7d
x-ms-traffictypediagnostic: AM6PR0202MB3383:
x-microsoft-antispam-prvs: <AM6PR0202MB33833051474490016CE16797B8710@AM6PR0202MB3383.eurprd02.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-forefront-prvs: 02213C82F8
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(396003)(376002)(39840400004)(136003)(366004)(189003)(199004)(71200400001)(6436002)(5640700003)(81166006)(26005)(478600001)(81156014)(186003)(386003)(25786009)(8936002)(14444005)(50226002)(14454004)(256004)(76176011)(6486002)(71190400001)(8676002)(102836004)(2906002)(52116002)(316002)(5660300002)(36756003)(86362001)(4326008)(66556008)(66476007)(66446008)(1361003)(6506007)(64756008)(99286004)(6512007)(7736002)(305945005)(2501003)(66946007)(446003)(1076003)(486006)(2616005)(476003)(6116002)(3846002)(11346002)(2351001)(66066001)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:AM6PR0202MB3383;H:AM6PR0202MB3382.eurprd02.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: habana.ai does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: G1xhc4XkkuXC3AYANv8rstzKCBiHP6/bf3ch2azQArI2T3fTlflOkLq5Frwl3RF6Z6yfCpleIgUsJf883mvUssPCKWLxzemAfx020Y9aRx3DxxbEHmV5D/RvMO8YbizR0K5LanNQ4Y+5C7eAHV4SM0/kzmSeyFKxplt3s+bQCP/YhSQSj6SBMSPlbW0eZV9RPTVULlSyNt2viShOTP6VpgBXqAbWpm9wCgD+nByNFXB0SvkHQMwvLDTAZQCVHyKSwgHRpRbaK9DNIZC2fY70+1EXqIRTTlDwdkOKMf6hQwcJJyg92AZYrmZabesOERTY35WmHWQnoK6+3uMN//P8h5SKCh/lmO4hbJVtgnY+e4inxxHm1GnQlKCpwEu/aNlgahslXXYnbBvpzXhZ1eQT58n83bj0sNxgl93VzqfLY7P0vWpP8I8q3qpDMdsXbIsG
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: habana.ai
X-MS-Exchange-CrossTenant-Network-Message-Id: c682d378-6d64-4b34-24c4-08d7692fcf7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2019 18:23:56.5057
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0d4d4539-213c-4ed8-a251-dc9766ba127a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N9CcPxV//QGyf5PhzdnFybDpY0QwkUdGr9yLsGGiWMqidr6L7lpYgFBkeETTfLd4GLhueFzZISe5RF3fNQBP1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0202MB3383
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

During hard reset we should not access the device except of necessary
reset operations because the device might be stuck or unresponsive.

Signed-off-by: Omer Shpigelman <oshpigelman@habana.ai>
---
 drivers/misc/habanalabs/goya/goya.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/=
goya/goya.c
index 3294a6a92f75..2935e84fe7d8 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -4870,7 +4870,8 @@ static void goya_mmu_invalidate_cache(struct hl_devic=
e *hdev, bool is_hard,
 	u32 status, timeout_usec;
 	int rc;
=20
-	if (!(goya->hw_cap_initialized & HW_CAP_MMU))
+	if (!(goya->hw_cap_initialized & HW_CAP_MMU) ||
+		hdev->hard_reset_pending)
 		return;
=20
 	/* no need in L1 only invalidation in Goya */
@@ -4909,7 +4910,8 @@ static void goya_mmu_invalidate_cache_range(struct hl=
_device *hdev,
 	u32 status, timeout_usec, inv_data, pi;
 	int rc;
=20
-	if (!(goya->hw_cap_initialized & HW_CAP_MMU))
+	if (!(goya->hw_cap_initialized & HW_CAP_MMU) ||
+		hdev->hard_reset_pending)
 		return;
=20
 	/* no need in L1 only invalidation in Goya */
--=20
2.17.1