Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Nov 2019 20:59:41 +0100
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Andrey Skvortsov <andrej.skvortzov@gmail.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: tps65910: allow using RTC without alarm interrupt
Message-ID: <20191114195941.GL3572@piout.net>
References: <20191109154652.7419-1-andrej.skvortzov@gmail.com>
 <20191111171915.GA3572@piout.net>
 <20191113230805.GH13629@skv.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191113230805.GH13629@skv.local>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 14/11/2019 02:08:05+0300, Andrey Skvortsov wrote:
> > >  static int tps65910_rtc_probe(struct platform_device *pdev)
> > >  {
> > >  	struct tps65910 *tps65910 = NULL;
> > > @@ -415,13 +422,17 @@ static int tps65910_rtc_probe(struct platform_device *pdev)
> > >  		tps65910_rtc_interrupt, IRQF_TRIGGER_LOW,
> > >  		dev_name(&pdev->dev), &pdev->dev);
> > >  	if (ret < 0) {
> > > -		dev_err(&pdev->dev, "IRQ is not free.\n");
> > > -		return ret;
> > > +		dev_err(&pdev->dev, "request IRQ:%d failed, err = %d\n",
> > > +			 irq, ret);
> > 
> > Do we actually need an error message here?
> 
> You are right. This is definitely not an error anymore.
> What about
> dev_warn(&pdev->dev, "unable to request IRQ, alarms disabled\n");
> like some other drivers do?
> 

Yes, or that can be left out completely as userspace will be able to
know whether alarms are supported without this message.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com