Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Nov 2019 15:16:07 -0600
From:   Rob Herring <robh@kernel.org>
To:     Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc:     mark.rutland@arm.com, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: media: renesas,ceu: Convert to yaml
Message-ID: <20191114211607.GA4896@bogus>
References: <20191111120017.83161-1-jacopo+renesas@jmondi.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191111120017.83161-1-jacopo+renesas@jmondi.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 11, 2019 at 01:00:17PM +0100, Jacopo Mondi wrote:
> Convert the Renesas CEU bindings description to json-schema and remove
> the existing textual bindings document.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  .../devicetree/bindings/media/renesas,ceu.txt | 86 -------------------
>  .../bindings/media/renesas,ceu.yaml           | 72 ++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 73 insertions(+), 87 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/renesas,ceu.txt
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,ceu.yaml


> diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> new file mode 100644
> index 000000000000..3c4a4ff975ae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: GPL-2.0-only

If only Renesas authors, can you dual license.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,ceu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas Capture Engine Unit (CEU) Bindings
> +
> +maintainers:
> +  - Jacopo Mondi <jacopo+renesas@jmondi.org>
> +  - linux-renesas-soc@vger.kernel.org
> +
> +description: |+
> +  The Capture Engine Unit is the image capture interface found in the Renesas SH
> +  Mobile, R-Mobile and RZ SoCs. The interface supports a single parallel input
> +  with data bus width of 8 or 16 bits.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - renesas,r7a72100-ceu
> +      - renesas,r8a7740-ceu
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  port:
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +       endpoint:
> +         type: object
> +
> +         # Properties described in
> +         # Documentation/devicetree/bindings/media/video-interfaces.txt
> +         properties:
> +           hsync-active: true
> +           vsync-active: true
> +           field-even-active: false
> +           bus-width:
> +             enum: [8, 16]

These should all have 'default'.

> +
> +    required:
> +      - endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - port
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    ceu: ceu@e8210000 {
> +        reg = <0xe8210000 0x209c>;
> +        compatible = "renesas,r7s72100-ceu";
> +        interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> +
> +        port {
> +            ceu_in: endpoint {
> +                remote-endpoint = <&ov7670_out>;
> +                hsync-active = <1>;
> +                vsync-active = <0>;
> +            };
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 37a977cbac6f..feab894f7584 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10133,7 +10133,7 @@ L:	linux-media@vger.kernel.org
>  L:	linux-renesas-soc@vger.kernel.org
>  T:	git git://linuxtv.org/media_tree.git
>  S:	Supported
> -F:	Documentation/devicetree/bindings/media/renesas,ceu.txt
> +F:	Documentation/devicetree/bindings/media/renesas,ceu.yaml
>  F:	drivers/media/platform/renesas-ceu.c
>  F:	include/media/drv-intf/renesas-ceu.h
> 
> --
> 2.23.0
>