Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Asmaa Mnebhi <Asmaa@mellanox.com>
To:     Vijay Khemka <vijaykhemka@fb.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Corey Minyard <minyard@acm.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "openipmi-developer@lists.sourceforge.net" 
        <openipmi-developer@lists.sourceforge.net>
CC:     "cminyard@mvista.com" <cminyard@mvista.com>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "sdasari@fb.com" <sdasari@fb.com>
Subject: RE: [PATCH v5] drivers: ipmi: Support raw i2c packet in IPMB
Thread-Topic: [PATCH v5] drivers: ipmi: Support raw i2c packet in IPMB
Thread-Index: AQHVmx5eMhFHRaYab0mtud1fguHZb6eLJujA
Date:   Thu, 14 Nov 2019 21:41:10 +0000
Message-ID: <DB6PR0501MB2712B06FB162520F90EF1F4DDA710@DB6PR0501MB2712.eurprd05.prod.outlook.com>
References: <20191114185359.2832107-1-vijaykhemka@fb.com>
In-Reply-To: <20191114185359.2832107-1-vijaykhemka@fb.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 50307b50-ed2f-4a39-525e-08d7694b5d9c
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2019 21:41:10.7635
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 58jL0LM8sXrbpPJ57jXUn6fTh2nPz21toFIbeDwnUPffH14nWRMwXmDED2x0aB+zOt2PgMMO8E07aqoIiBt+kA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2581
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


-----Original Message-----
From: Vijay Khemka <vijaykhemka@fb.com>=20
Sent: Thursday, November 14, 2019 1:54 PM
To: Jonathan Corbet <corbet@lwn.net>; Corey Minyard <minyard@acm.org>; Arnd=
 Bergmann <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>;=
 linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; openipmi-develope=
r@lists.sourceforge.net
Cc: vijaykhemka@fb.com; cminyard@mvista.com; Asmaa Mnebhi <Asmaa@mellanox.c=
om>; joel@jms.id.au; linux-aspeed@lists.ozlabs.org; sdasari@fb.com
Subject: [PATCH v5] drivers: ipmi: Support raw i2c packet in IPMB

Many IPMB devices doesn't support smbus protocol and current driver support=
 only smbus devices. Added support for raw i2c packets.

User can define i2c-protocol in device tree to use i2c raw transfer.

Asmaa >> It would be good if you can rephrase the above description as foll=
ows:
"The ipmb_dev_int driver only supports the smbus protocol at the moment. Ad=
d support for the i2c protocol as well. There will be a variable passed by =
the device tree or ACPI table which determines whether the protocol is i2c =
or smbus."

Or at least fix the following:=20
"Many IPMB devices doesn't" -> "Many IPMB devices don't"
"current driver support" -> "current driver supports"

Besides my above comment:
Reviewed-by: Asmaa Mnebhi <asmaa@mellanox.com>

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
 Documentation/IPMB.txt           |  4 ++++
 drivers/char/ipmi/ipmb_dev_int.c | 29 +++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)

diff --git a/Documentation/IPMB.txt b/Documentation/IPMB.txt index a6ed8b68=
bd0f..7a023beff976 100644
--- a/Documentation/IPMB.txt
+++ b/Documentation/IPMB.txt
@@ -71,9 +71,13 @@ b) Example for device tree:
          ipmb@10 {
                  compatible =3D "ipmb-dev";
                  reg =3D <0x10>;
+                 i2c-protocol;
          };
 };
=20
+If xmit of data to be done using raw i2c block vs smbus then=20
+"i2c-protocol" needs to be defined as above.
+
 2) Manually from Linux:
 modprobe ipmb-dev-int
=20
diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_=
int.c
index ae3bfba27526..68a254c0dd92 100644
--- a/drivers/char/ipmi/ipmb_dev_int.c
+++ b/drivers/char/ipmi/ipmb_dev_int.c
@@ -63,6 +63,7 @@ struct ipmb_dev {
 	spinlock_t lock;
 	wait_queue_head_t wait_queue;
 	struct mutex file_mutex;
+	bool is_i2c_protocol;
 };
=20
 static inline struct ipmb_dev *to_ipmb_dev(struct file *file) @@ -112,6 +1=
13,25 @@ static ssize_t ipmb_read(struct file *file, char __user *buf, size=
_t count,
 	return ret < 0 ? ret : count;
 }
=20
+static int ipmb_i2c_write(struct i2c_client *client, u8 *msg, u8 addr)=20
+{
+	struct i2c_msg i2c_msg;
+
+	/*
+	 * subtract 1 byte (rq_sa) from the length of the msg passed to
+	 * raw i2c_transfer
+	 */
+	i2c_msg.len =3D msg[IPMB_MSG_LEN_IDX] - 1;
+
+	/* Assign message to buffer except first 2 bytes (length and address) */
+	i2c_msg.buf =3D msg + 2;
+
+	i2c_msg.addr =3D addr;
+	i2c_msg.flags =3D client->flags & I2C_CLIENT_PEC;
+
+	return i2c_transfer(client->adapter, &i2c_msg, 1); }
+
 static ssize_t ipmb_write(struct file *file, const char __user *buf,
 			size_t count, loff_t *ppos)
 {
@@ -133,6 +153,12 @@ static ssize_t ipmb_write(struct file *file, const cha=
r __user *buf,
 	rq_sa =3D GET_7BIT_ADDR(msg[RQ_SA_8BIT_IDX]);
 	netf_rq_lun =3D msg[NETFN_LUN_IDX];
=20
+	/* Check i2c block transfer vs smbus */
+	if (ipmb_dev->is_i2c_protocol) {
+		ret =3D ipmb_i2c_write(ipmb_dev->client, msg, rq_sa);
+		return (ret =3D=3D 1) ? count : ret;
+	}
+
 	/*
 	 * subtract rq_sa and netf_rq_lun from the length of the msg passed to
 	 * i2c_smbus_xfer
@@ -302,6 +328,9 @@ static int ipmb_probe(struct i2c_client *client,
 	if (ret)
 		return ret;
=20
+	ipmb_dev->is_i2c_protocol
+		=3D device_property_read_bool(&client->dev, "i2c-protocol");
+
 	ipmb_dev->client =3D client;
 	i2c_set_clientdata(client, ipmb_dev);
 	ret =3D i2c_slave_register(client, ipmb_slave_cb);
--
2.17.1