Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Nov 2019 22:51:54 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Giovanni Mascellani <gio@debian.org>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm-hwmon) Disable BIOS fan control on
 SET_FAN
Message-ID: <20191114215154.hze2avicv7pwiksp@pali>
References: <20191114211408.22123-1-gio@debian.org>
 <20191114213901.GA28532@roeck-us.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="qyg2dmvyfnwsnflo"
Content-Disposition: inline
In-Reply-To: <20191114213901.GA28532@roeck-us.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--qyg2dmvyfnwsnflo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thursday 14 November 2019 13:39:01 Guenter Roeck wrote:
> I can see two possibilities: Either add a pwm1_enable attribute to
> be able to set manual/automatic fan control,

I already proposed such patch in past:
https://patchwork.kernel.org/patch/9130921/

> > @@ -43,6 +49,8 @@
> >  #define I8K_SMM_GET_TEMP_TYPE	0x11a3
> >  #define I8K_SMM_GET_DELL_SIG1	0xfea3
> >  #define I8K_SMM_GET_DELL_SIG2	0xffa3
> > +#define I8K_SMM_DISABLE_BIOS	0x30a3
> > +#define I8K_SMM_ENABLE_BIOS	0x31a3

This is model or BIOS specific. For example on E6440 are used 0x34a3 /
0x35a3 SMM calls. Because of these platform specific problems we have
never incorporated this patch into mainline kernel.

Also note that userspace can issue those SMM commands on its own (via
sys_iopl or sys_ioperm), fully bypassing such "protection" proposed in
this new patch.

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--qyg2dmvyfnwsnflo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXc3MeAAKCRCL8Mk9A+RD
UvWYAJ9O9wwQgkPz8MsClELRJDVyVIhAqwCgtdzteh/xzor3GbpmAGf4IvDv9j4=
=j2gv
-----END PGP SIGNATURE-----

--qyg2dmvyfnwsnflo--