Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3925892ybc; Thu, 14 Nov 2019 17:26:22 -0800 (PST) X-Google-Smtp-Source: APXvYqypSUySAhZpJ0iQMc6ECydL7wq/nVdU6fU8yH5wP8q4xWVa8gtcfFHRjR6SnDM/sLm66Ppc X-Received: by 2002:a17:907:110f:: with SMTP id qu15mr9826524ejb.179.1573781182654; Thu, 14 Nov 2019 17:26:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573781182; cv=none; d=google.com; s=arc-20160816; b=fopr3B+uLeTtWt35nZ8H0U5UK/n42HOD4fmjbaxGQMq8WAgeHr8e1NlsmoN5efatz+ 2aOvlF8PlKz8+sOcD0fdH2jhmN2i6JCHCNAj85WrVT1lAbqr/lfaD7u3npXA9+XsQYYF AITf6/1G2X2WnpQSGe4jbZmP8oL78JT2XbRTGuov0XbyoYOmfq2Yi0nOz/DKz6Zj+xuo w9l8f5fMz8ndJ23NZBEd3BbWBFlp6fJpQIgLVwmxfqYrn9HSjiuQlXcOSJt2WXl2ltcl 71kljruL0UUcJomN3VJtMUzmws2kmReNYCbcQ4SWoy8DI7H1vQ62QJUIpr5qr4Q6z1Ck Y1hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=rbE1Wcsirza2JaW+3utZn4hbrXpX5xNM8bL08eDqpyw=; b=ruOwf7JEuep7H2KZMCiXh3IXKhoyjBWjh1SiQPMWAYB9X++grwSBLdr7P0Aboym4cJ ikMA6RHDXqfmIjLsHV81Rle2Ih208zFRn2yQ8e6UQQGD4BMy/Lr8ZqmkwoqeukR/OuNH IE2CEVO9TG0VS/m/lJzM7CQAvmRwoI/3EbfyVJ5SfXLiRKXaNPWduiN1/eWmIox7UKoF +az+pL0nc+oXefPja/Jy743ntKOwrVQdvzb0bm33jphjqRB/WKr4FcgzVqpeGfj82X+Z gBbVktHky7EcToKNbZYPxe85IHo/3cPl/8dBdFbUzUtEExi5GdF2uFhhgSKimV9FaxG4 oz+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=qjvFTPBg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e15si5393476eda.106.2019.11.14.17.25.57; Thu, 14 Nov 2019 17:26:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=qjvFTPBg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbfKOBWp (ORCPT + 99 others); Thu, 14 Nov 2019 20:22:45 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:46027 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727022AbfKOBWo (ORCPT ); Thu, 14 Nov 2019 20:22:44 -0500 Received: by mail-lf1-f67.google.com with SMTP id v8so6629099lfa.12 for ; Thu, 14 Nov 2019 17:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rbE1Wcsirza2JaW+3utZn4hbrXpX5xNM8bL08eDqpyw=; b=qjvFTPBgFXYbB5WdseQRUdly8Y8CbuMcAAcDxORIfmdVQS99H/oqvGy8WoF96Tg7A+ n2YmgRm6wt8AA9LrPXu2b/aspr0DYORzzcudOogpl9P9ditcW6nnwA/1v9B+MLV077dM MSod2kWwlGFXQQrBokWh0PhHbF6L7khF7M67SFJ6gb/MFXEocLfBhboQbz4/yF1sC9rK 8f1/RXUBhcSFNSFfdPpc8baOHrvdGEdH5Lo8aoKcGlDBeeHB7Sr6aJF+uFvp9iPYTbuv 5+a8xXS01xAajSZj5AiRN53uswZtj1Hltsb6Wln1LzhHdYiiXudnLqLVeBFJENJWr3g9 ZnUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rbE1Wcsirza2JaW+3utZn4hbrXpX5xNM8bL08eDqpyw=; b=EV0+EdTVBdY2u9LUyEvbUf1DKMEntDGOlGLVG35htuVgWXWWEABPsNPRl/59J/1eH6 YASKj4sWp/jMUK+MWw+0oO1bX6r5h91xGhpZ1Yn2wbxKTuXP+UxCljO9JFnw+oMIhrbd gdlAN2vQPsliJ9GegNgFGSpVJ1mNCLpa0huAFFsz7FTnBBDGhxb44Qj3nvG4xE0x9gt4 ExrRA0fITqfgXvmY38xloZNgefCsqY/vX0e/wLeA9c2KKZz8uEUfedC+DCG8faT9WzTP bzqY2g5xU0tUvQSli/QeGkGs/FDRmOY2rKPDvVuImdPffD44S2iZd8mR18s9AoM/dV2f akWA== X-Gm-Message-State: APjAAAUHBlNsO/Vx/vOFhlCVnBNIYiyaicwkvFvUNVbcAouvn9QDGcqy fnmVsvQc17VVlTO5jz/nQzFDMIHAc9bWDMMXG4d8Tg== X-Received: by 2002:a19:22d3:: with SMTP id i202mr8959655lfi.69.1573780962459; Thu, 14 Nov 2019 17:22:42 -0800 (PST) MIME-Version: 1.0 References: <20190710201244.25195-1-brijesh.singh@amd.com> <20190710201244.25195-12-brijesh.singh@amd.com> In-Reply-To: <20190710201244.25195-12-brijesh.singh@amd.com> From: Steve Rutherford Date: Thu, 14 Nov 2019 17:22:06 -0800 Message-ID: Subject: Re: [PATCH v3 11/11] KVM: x86: Introduce KVM_SET_PAGE_ENC_BITMAP ioctl To: "Singh, Brijesh" Cc: "kvm@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Borislav Petkov , "Lendacky, Thomas" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2019 at 1:13 PM Singh, Brijesh wrote: > > struct kvm_arch_async_pf { > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index e675fd89bb9a..31653e8d5927 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -7466,6 +7466,47 @@ static int svm_get_page_enc_bitmap(struct kvm *kvm, > return ret; > } > > +static int svm_set_page_enc_bitmap(struct kvm *kvm, > + struct kvm_page_enc_bitmap *bmap) > +{ > + struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; > + unsigned long gfn_start, gfn_end; > + unsigned long *bitmap; > + unsigned long sz, i; > + int ret; > + > + if (!sev_guest(kvm)) > + return -ENOTTY; > + > + gfn_start = bmap->start_gfn; > + gfn_end = gfn_start + bmap->num_pages; > + > + sz = ALIGN(bmap->num_pages, BITS_PER_LONG) / 8; > + bitmap = kmalloc(sz, GFP_KERNEL); This kmalloc should probably be either a vmalloc or kvmalloc. The max size, if I'm reading kmalloc correctly, is 2^10 pages. That's 4MB, which should correspond to a bitmap for a 128GB VM, which is a plausible VM size. --Steve