Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191111030434.29977-1-afaerber@suse.de> <20191111030434.29977-6-afaerber@suse.de>
In-Reply-To: <20191111030434.29977-6-afaerber@suse.de>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Thu, 14 Nov 2019 19:34:47 -0600
Message-ID: <CAL_Jsq+fdksCHQ1_NaizkM6dVWT1h2wocJpD4NB8K2dOO-yZ4Q@mail.gmail.com>
Subject: Re: [PATCH 5/7] ARM: dts: rtd1195: Introduce r-bus
To:     =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc:     linux-realtek-soc@lists.infradead.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Nov 10, 2019 at 9:04 PM Andreas F=C3=A4rber <afaerber@suse.de> wrot=
e:
>
> Model Realtek's register bus in DT.
>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  This could be squashed into the original RTD1195 patch.
>
>  arch/arm/boot/dts/rtd1195.dtsi | 52 ++++++++++++++++++++++++------------=
------
>  1 file changed, 30 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rtd1195.dtsi b/arch/arm/boot/dts/rtd1195.d=
tsi
> index a8cc2d23e7ef..3439647ecf97 100644
> --- a/arch/arm/boot/dts/rtd1195.dtsi
> +++ b/arch/arm/boot/dts/rtd1195.dtsi
> @@ -92,28 +92,36 @@
>                          <0x18100000 0x18100000 0x01000000>,
>                          <0x40000000 0x40000000 0xc0000000>;
>
> -               wdt: watchdog@18007680 {
> -                       compatible =3D "realtek,rtd1295-watchdog";
> -                       reg =3D <0x18007680 0x100>;
> -                       clocks =3D <&osc27M>;
> -               };
> -
> -               uart0: serial@18007800 {
> -                       compatible =3D "snps,dw-apb-uart";
> -                       reg =3D <0x18007800 0x400>;
> -                       reg-shift =3D <2>;
> -                       reg-io-width =3D <4>;
> -                       clock-frequency =3D <27000000>;
> -                       status =3D "disabled";
> -               };
> -
> -               uart1: serial@1801b200 {
> -                       compatible =3D "snps,dw-apb-uart";
> -                       reg =3D <0x1801b200 0x100>;
> -                       reg-shift =3D <2>;
> -                       reg-io-width =3D <4>;
> -                       clock-frequency =3D <27000000>;
> -                       status =3D "disabled";
> +               rbus: r-bus@18000000 {

Following node names should be generic: bus@...

> +                       compatible =3D "simple-bus";
> +                       reg =3D <0x18000000 0x100000>;
> +                       #address-cells =3D <1>;
> +                       #size-cells =3D <1>;
> +                       ranges =3D <0x0 0x18000000 0x100000>;
> +
> +                       wdt: watchdog@7680 {
> +                               compatible =3D "realtek,rtd1295-watchdog"=
;
> +                               reg =3D <0x7680 0x100>;
> +                               clocks =3D <&osc27M>;
> +                       };
> +
> +                       uart0: serial@7800 {
> +                               compatible =3D "snps,dw-apb-uart";
> +                               reg =3D <0x7800 0x400>;
> +                               reg-shift =3D <2>;
> +                               reg-io-width =3D <4>;
> +                               clock-frequency =3D <27000000>;
> +                               status =3D "disabled";
> +                       };
> +
> +                       uart1: serial@1b200 {
> +                               compatible =3D "snps,dw-apb-uart";
> +                               reg =3D <0x1b200 0x100>;
> +                               reg-shift =3D <2>;
> +                               reg-io-width =3D <4>;
> +                               clock-frequency =3D <27000000>;
> +                               status =3D "disabled";
> +                       };
>                 };
>
>                 gic: interrupt-controller@ff011000 {
> --
> 2.16.4
>