Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4007239ybc; Thu, 14 Nov 2019 19:25:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzAL+NMZ9AvRk+fSuOO6wAS02YQTe9wI4LXzzlACEzF2ETlYnUwBzwtQtALFsbn1cfhgPJR X-Received: by 2002:a17:906:1c4d:: with SMTP id l13mr10305150ejg.308.1573788353328; Thu, 14 Nov 2019 19:25:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573788353; cv=none; d=google.com; s=arc-20160816; b=mWWWRY5vjQYJvdDhLvZqxmzbdSwHOZVsc5f7DSkV/0L4/JM2gnahoDx3pyII0bkDhH RoD2utxsxIstFgqRW4glIfhPMtVQONHYFffLxKHf1bvvlqk/DAOI2ZY6ovGI15W75Pd1 qVULntbLzfi+ZfPWJKyvSRn7ooSWFo1DA7maCCEnAHOvsz2vnO37oz6aeqpjW+BkmefN kcbVDbIORnGgEZkGVn3jn1Mno1IKgVgiTblb2GfutjjPuYTpUj/bPVpEnQQR+Up1IW1l f6SuNoQJvzDt9UG/Qc5YsVS27BFeH+5d3x4/o56E7u3ZCS6uvRoZHAFKrqv2r6iFB/P9 F1Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=W4z1sHTvZXn+wigsZ7x6o7r5zSO9vraGNYBO3HvERjI=; b=eAFSkcHCvXoSZzitOZDbjofjCeBjHz4SSaM/hwgE0wBostB/v5d6s+iHXeoJqjoiD8 VYWHf56+CCwH01VAerJoKme+th5vX6bZ+YfS650mA5ODqjrA6REFFL8xYZ2N3mInOeTy 3BNhYiHNmzBxZ5XY+WeuWgzePJiHQ9efooBibwEKvGWniIQyTcdtjUY1wfsh0SWYlTH+ 9y7HRcwJueha+GqMVQEX5rSrzt6KlyraJoypT5bWiQGP00rn0/H9KVNP6vcfZFQozdTd s5p+HPn3WtZVoZHgHayXX+N271mcakBJvkSCy6GR+QuYBqhvXRooFU3OnrjoMBrDbHNx Z/6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="JR2qBG/t"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si6216970edm.231.2019.11.14.19.25.29; Thu, 14 Nov 2019 19:25:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="JR2qBG/t"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727133AbfKODV5 (ORCPT + 99 others); Thu, 14 Nov 2019 22:21:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:38084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726533AbfKODV5 (ORCPT ); Thu, 14 Nov 2019 22:21:57 -0500 Received: from localhost (unknown [104.132.150.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D03720706; Fri, 15 Nov 2019 03:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573788116; bh=8/cY/P7mOC5ZWRzkTqP24RnTXXHa15NbkFVIzTSK364=; h=Date:From:To:Subject:References:In-Reply-To:From; b=JR2qBG/tbs+2u/BVDVXsZprjTey36G9Dh+snSLlcAX1kxtk0l/rMWe3cwt4MlhdCq 5+ZfbOGgxzp29+cn8YPcISIO/YK4QCO4q0+1cz43bS73NJanBJf/fA8r/Yp3jRS/Yf 1RbyPZ7FUwo1BaJ36gTF8p0Kq3zbdl2nqTCaTAw0= Date: Fri, 15 Nov 2019 11:21:53 +0800 From: Greg Kroah-Hartman To: Bin Liu , Chunfeng Yun , Felipe Balbi , Laurent Pinchart , Mauro Carvalho Chehab , Peter Chen , Minas Harutyunyan , Cristian Birsan , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kevin Cernekee , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Matthias Brugger , Stephen Boyd , Yoshihiro Shimoda , Colin Ian King , Biju Das , Fabrizio Castro , "Gustavo A. R. Silva" , Yangtao Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 05/13] usb: musb: create debugfs directory under usb root Message-ID: <20191115032153.GC793701@kroah.com> References: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> <1573541519-28488-5-git-send-email-chunfeng.yun@mediatek.com> <20191112152857.GA5853@uda0271908> <20191114032018.GA122287@kroah.com> <20191114140234.GB5853@uda0271908> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191114140234.GB5853@uda0271908> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 14, 2019 at 08:02:34AM -0600, Bin Liu wrote: > On Thu, Nov 14, 2019 at 11:20:18AM +0800, Greg Kroah-Hartman wrote: > > On Tue, Nov 12, 2019 at 09:28:57AM -0600, Bin Liu wrote: > > > Hi, > > > > > > On Tue, Nov 12, 2019 at 02:51:51PM +0800, Chunfeng Yun wrote: > > > > Now the USB gadget subsystem can use the USB debugfs root directory, > > > > so move musb's directory from the root of the debugfs filesystem into > > > > the root of usb > > > > > > My opinion is this move is unnecessary. I breaks existing debug tools or > > > documentation which is already published on Internet. > > > > Having a "root" directory for a single random driver seems like you are > > making your driver a "very important" thing in the overall scheme of the > > kernel, right? What's wrong with using the usb subdirectory like all > > Agree, it wasn't the right thing to do at the first place. But now > changing it adds support burden, because people very often refer to the > old information on the internet which no longer matches to the new > location. Basically, it is a cost of ABI change. What information says that /sys/kernel/debug/mdev/ is the location for this? Is it in-kernel? > > other USB drivers use (after this patch series is merged)? That feels > > like a much more "sane" way to handle the wide-open debugfs namespace. > > Though I commented on this musb patch, my opinion is for this whole > series, either drop the whole series or apply the whole series. I've applied all but this one and 2 others that did not build properly. > > Yes, there are no rules when it comes to debugfs file names and > > locations, but let's try to be sane please. > > Fine with me. I can still support questions such as "can't open > /sys/kernel/debug/musb-hdrc.0/testmode: No such file or directory". What tool looks for that? thanks, greg k-h