Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4010393ybc; Thu, 14 Nov 2019 19:30:59 -0800 (PST) X-Google-Smtp-Source: APXvYqyaaS84kpgxKFv/XyBAsnz4osXWmgPTIwEcrYDG8vVrrb763R1Rl204+Jmm4VwleGJWIi4o X-Received: by 2002:a17:906:e289:: with SMTP id gg9mr10485401ejb.71.1573788659807; Thu, 14 Nov 2019 19:30:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573788659; cv=none; d=google.com; s=arc-20160816; b=ppiTjvGhThupfSaGMT0UeYPrbGWKSiwrwmx0H6XFhzvyW1Ekp/kP1qUS8V+FrmyZWn bM3Jhsun6jwCnWC3Bdgt37rTJN33SdlRODBXdcXBoJFhW+cZvip08yLcrdO+i3X/0HJi E4LuEyOKFuZdw4rtwafPl1Pq87NEDox4srLRjsMkTMJIfEr5EQ40e+GUECd4Wsyvhn8A 9LKJ1SiOc9WAH2VjDOaT9e9Q0uqVppjsRZbB/phmxjjhADkq++AHtrOJNcxpgbzVaxc2 GrpKt5N/6pTqIg4abVJGVWnMSITejhNg+WyIkmTq0hW1bLgB5wfxZIFtB7cB+n6GwqqW cHcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=D+30VBQ6Z6pahGzwHddR4V87xEKzy9SO3iX26pCuliI=; b=I6LU7LIUBu4pLl7ltbDegLxasQO/pSPyxkTbxRFnsJ3piL0FHGCEGwMiFHpoel+E5k 7TdEKGBHF76ZpH7rNo46A+RQk0fIeBLEBuTqWO9gbnyc2eEj8XxvgfFa814aoZeYXI8V yiqpwTLDNvGpeifyQpiWv3+0dMrVsW8fkQBHx5p9vAA3OJZP0SRxeoi+v9JRLYWQAODn +r1tBAft/mhVDUfBPDedCH/858WvBvjOS7ABoPx949KwtDiEnver2uiVNe+z8HdTEyqa y5NktqqxP9MElgnswd4EsxrEfJu2yqP8ABD1M6wVDZsFU+yiUPNFmVZHiBKrJCPncJfZ pHXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nFIgWxCJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2si2441854edy.215.2019.11.14.19.30.34; Thu, 14 Nov 2019 19:30:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nFIgWxCJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbfKOD27 (ORCPT + 99 others); Thu, 14 Nov 2019 22:28:59 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:34128 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbfKOD27 (ORCPT ); Thu, 14 Nov 2019 22:28:59 -0500 Received: by mail-qk1-f195.google.com with SMTP id 205so7045651qkk.1; Thu, 14 Nov 2019 19:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D+30VBQ6Z6pahGzwHddR4V87xEKzy9SO3iX26pCuliI=; b=nFIgWxCJ2dZ8AUUfrv0rBQqDPsE/g8aWDwr4HMuPFIEKpaOIi6EVMubajiKEh6jCW6 H/RgXIFJXhd70OnQ6oObOTeMo0OhmLRkHOaadLiHuiD8yVVmWytBR7zy8oP2jEmZhBql kfAYz+Fql23qHA0/BEMZyoOajXF4G/DC27SKMpBNTEhizPcYGzrhMKw0fFh6MiqWXM3G ia9ou95D5ZtF1zj82ilfZRtVHz5t/7xNFTbsUPkJLCeKuhuo6rvZAASwybUzJT/rq0UD q13bwhOppW486v84zFWOGGfLR4L/nFDiL9FLLWNtr67JUaEKSVyLN3oHJip2bhNVFqbZ qFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D+30VBQ6Z6pahGzwHddR4V87xEKzy9SO3iX26pCuliI=; b=YMgGAT/GfyFEVfZ7NDxiWm8jUVd/y74dy9VbjVwfV2nW+etj8UVts+KueDOZAXcjQ9 petPunoqUPC1ZSMwL8gEvcNbYQ3/ik1tQjdXAYo40sLoiCVh3CqG0/2hOae3kxhJtc9l CNEVz4Scxiokclt2X2fSCmlT2B+RfxAK8LbRkCFzI2ULPh+cZSmgwgV+IwneU6RLxEQY yMKYZG3qv1Iyfp+daWEjKzXebRERWH+l0KAT4YWZN4qbaeVtkmgxNYmtz1kTT7Ekf/Tk Z5r6g238eC/DVsvNPCVT3wxruRnPGFXH1UCXWFu4d0IRs1LIOAnVTdhMgGYhpufqmX1j FLvQ== X-Gm-Message-State: APjAAAWRBXZlLUf8CpaUEMO/BgBJPnC5LUMWE1ArHpunkAqsIASKKhiE ABHENnPn3E1zr6BlOQI8XHEkpP/bazGEVXrGdrsHWg== X-Received: by 2002:a37:4b97:: with SMTP id y145mr10563545qka.133.1573788538446; Thu, 14 Nov 2019 19:28:58 -0800 (PST) MIME-Version: 1.0 References: <0a6b113010ad772a633b9cfeeb280dc41f17b951.1573206815.git.baolin.wang@linaro.org> <20191114180233.GA14860@bogus> In-Reply-To: <20191114180233.GA14860@bogus> From: Baolin Wang Date: Fri, 15 Nov 2019 11:28:46 +0800 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: thermal: sprd: Add the Spreadtrum thermal documentation To: Rob Herring Cc: Baolin Wang , rui.zhang@intel.com, edubezval@gmail.com, daniel.lezcano@linaro.org, amit.kucheria@verdurent.com, mark.rutland@arm.com, Orson Zhai , freeman.liu@unisoc.com, Chunyan Zhang , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Fri, Nov 15, 2019 at 2:02 AM Rob Herring wrote: > > On Fri, Nov 08, 2019 at 05:54:30PM +0800, Baolin Wang wrote: > > From: Freeman Liu > > > > Add the Spreadtrum thermal documentation. > > > > Signed-off-by: Freeman Liu > > Signed-off-by: Baolin Wang > > --- > > .../devicetree/bindings/thermal/sprd-thermal.txt | 41 ++++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sprd-thermal.txt > > Please make this a schema. See Documentation/devicetree/writing-schema.rst OK. > > > > diff --git a/Documentation/devicetree/bindings/thermal/sprd-thermal.txt b/Documentation/devicetree/bindings/thermal/sprd-thermal.txt > > new file mode 100644 > > index 0000000..a9da7f4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sprd-thermal.txt > > @@ -0,0 +1,41 @@ > > +* Spreadtrum thermal sensor controller bindings > > + > > +Required properties: > > +- compatible : Should be "sprd,ums512-thermal" > > +- reg: Address range of the thermal registers > > +- clock-names: "enable" for thermal module enable clock. > > +- clocks: Should contain a clock specifier for each entry in clock-names. > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. > > +- nvmem-cell-names: Should be "thm_sign_cal" and "thm_ratio_cal". > > +- #thermal-sensor-cells: Should be 1. See ./thermal.txt for a description. > > + > > +Child nodes properties: > > +- reg: Specify the sensor id. > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. > > +- nvmem-cell-names: Should be "sen_delta_cal". > > + > > +Example: > > + > > + ap_thm0: thermal@32200000 { > > + compatible = "sprd,ums512-thermal"; > > + reg = <0 0x32200000 0 0x10000>; > > + clock-names = "enable"; > > + clocks = <&aonapb_gate CLK_THM0_EB>; > > + #thermal-sensor-cells = <1>; > > + nvmem-cells = <&thm0_sign>, <&thm0_ratio>; > > + nvmem-cell-names = "thm_sign_cal", "thm_ratio_cal"; > > + > > + prometheus0-sensor@0{ > > space ^ OK. Will fix. > > > + reg = <0>; > > + nvmem-cells = <&thm0_sen0>; > > + nvmem-cell-names = "sen_delta_cal"; > > + }; > > + > > + ank1-sensor@1{ > > space ^ Yes, will fix in next version. Thanks for your comments.