Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4217161ybc; Fri, 15 Nov 2019 00:34:07 -0800 (PST) X-Google-Smtp-Source: APXvYqyKGaIado67ZSW1hbK248G9gjeRQ/cU/SVzSTDy28lB4kaiFmaVKKz7/re2dJJGqR/FAEUp X-Received: by 2002:a17:906:751:: with SMTP id z17mr11867324ejb.313.1573806847815; Fri, 15 Nov 2019 00:34:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573806847; cv=none; d=google.com; s=arc-20160816; b=lZazi4hH03og6QPdvBIkDeP3chfj9qAXJCRq5w0qK2EYbH3Z/vESNbC56dxePM4LTN pTfQNXSbCPA6CJ8mDLEYG7OzPJJH2QvXEjX4xJmrFNnHwH1HhD6uhjYU3yqql6q4ySn/ uyN+49gKI7rVYGGiZ/TbaKfHl22OML1tUiOt/X69Ry19TQV/CVmlSqlZP9nwGt198vae m8A6qaYTqROvaRhV0/gatzjkFE8ydv+9TGlGoS0X5MF4zGGNSg0aJRzF2ESCJF/nNulm 4oB+WNVyYZO89I36CXTMFoaeErIOOuQBT7/Ee6N5Ldjnx5/A26qxwQ1HTUr/K8N+r2/x OzRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=OCpyp7VlXRWKtfspUgWzs1CQ4X3tbOzNUUacTAQ1h0c=; b=arHDH1A7q74yeXHZdXZugxa1JYebTPlzM4tB4f1/uW11EEo0BKX8ZYEblnCOetJr2W rxllx2IRKe6jFx3gSxDCjnLkf6Ym5TwZvAq7yIIq8+hT+pe+bVGas5LPcuxNOZduq5J/ cGI8fLJ/KDo+U5fVhD1x+SsABBHdUv5d1AH4bjoVfusESslgm3RFny1FkX2hrARyqxPt T3AuLRiuE6G3t63FMKWPsIrcmI+i7tbCzeO7t6OMQWJB8QMxrXbMzNfZzKySOB0PLDR6 zDEzicEvfF16RBs+LMsvBK6sXHXY0RUvvmcbICND1ZntCDSP6G2wQoTDZDpiJA09LX+F iZfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=LZe+lZUE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b49si5288306eda.312.2019.11.15.00.33.43; Fri, 15 Nov 2019 00:34:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=LZe+lZUE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727357AbfKOIcF (ORCPT + 99 others); Fri, 15 Nov 2019 03:32:05 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:37233 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfKOIcF (ORCPT ); Fri, 15 Nov 2019 03:32:05 -0500 Received: by mail-pl1-f194.google.com with SMTP id bb5so4135179plb.4; Fri, 15 Nov 2019 00:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OCpyp7VlXRWKtfspUgWzs1CQ4X3tbOzNUUacTAQ1h0c=; b=LZe+lZUE9hQ0aZNfcLDPsBUDHmfZCHMlwOVbI2C+0igiwcL1MTf0W975poTI0U68eB pLruGRp9Rg+UyjBzHaPBZAhlQcY2u3sNvfNc98fDmx+pBAJ4Sjt6MVHCQ0hApcKbE0Uf BgF81Q7dq5gh5dxlQTLrWO/jH0lwkpusB3Gq7XW4AWn1QyOGHGrmhNNbacLxDh5uergJ DRipIURtIrxwBVvDeWcnZ4sOyn6mF8WzBrWhhPqNRk442OB6JYWxPLjH6GOZkqH2Aa37 0fiD1SMcsIUYD3RxEdroAnDxKGLbiZLvL5fvnOvzuwGll+AIZPufdYBfIG4IrkWNBN+d 2bEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OCpyp7VlXRWKtfspUgWzs1CQ4X3tbOzNUUacTAQ1h0c=; b=WsnRKD9qFoRDgJbmEpNbTywCUddaSYV2ZqNACgS7dDO62iDo1lpIFjEl2FAJgi80h6 Y+uWunsZeiLxHZ8HRl3cDhyByBVVPMUuAssnqapc9LsbG70P8WRyFDH3da1ntARKy3G4 rsXxxQGZgOPLIkz2to2xFmLLl+JexF6GclG3B1qCC/232lZcdTY4CXGelc1DHMgiVWCK cyYbB18vx+E5H8D1exadYF8yjL0OH90PcNIpy6Op7qm0BEYB7OUFZtLfyCSKmNYglE4y CdIT2okd5Z7bEElx2JGFo0MIsPAOxM+RsXRWO5dnXlC0+kfLKRT4VFYOIRrcYV1c6f+9 reww== X-Gm-Message-State: APjAAAVl2Ud2UMprZQskHDJcGXo1/aREBjJK7OLg5Y49wbmFE4BCOf3U dYXEUOgbZEJDAelv+rFdGlw= X-Received: by 2002:a17:902:ab98:: with SMTP id f24mr7023396plr.257.1573806724797; Fri, 15 Nov 2019 00:32:04 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id z4sm9190597pfn.80.2019.11.15.00.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 00:32:04 -0800 (PST) From: Chuhong Yuan Cc: Dan Williams , Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH 2/2] dmaengine: mmp_pdma: add missed of_dma_controller_free Date: Fri, 15 Nov 2019 16:31:53 +0800 Message-Id: <20191115083153.12334-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver calls of_dma_controller_register in probe but does not free it in remove. Add the call to fix it. Signed-off-by: Chuhong Yuan --- drivers/dma/mmp_pdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index 7fe494fc50d4..ad06f260e907 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -945,6 +945,8 @@ static int mmp_pdma_remove(struct platform_device *op) struct mmp_pdma_phy *phy; int i, irq = 0, irq_num = 0; + if (op->dev.of_node) + of_dma_controller_free(op->dev.of_node); for (i = 0; i < pdev->dma_channels; i++) { if (platform_get_irq(op, i) > 0) -- 2.24.0