Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4275681ybc; Fri, 15 Nov 2019 01:53:23 -0800 (PST) X-Google-Smtp-Source: APXvYqwJ+cC8NttqTQmkgiybX/vHpqySgOw6lF6ehMKi5Rts56ftSnTKAuyO4mvYQtssHaiGgcsh X-Received: by 2002:a17:906:404d:: with SMTP id y13mr12880302ejj.276.1573811603283; Fri, 15 Nov 2019 01:53:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573811603; cv=none; d=google.com; s=arc-20160816; b=D1Oul0gX9iP1RxBQb5z9llbz1MoSqXg/quTimoEVi4ceSHFBFGA/uO07vtW/CHC9Z6 RvuKpvKHsZEWTN+jHAw2Y5Yx/5yEI0cVM8k0LmHn1YiQvMmqpzQ0svucs4zNmt/tWHoc wBTHopbLFlMPTVG+ssJF36nKaBe49gIdEc5JxCz/CV73MPB7l2V5xmqytiDZobcgrExK A9wIqoNahTw751Iv2FfjgeEOzf6NO+Zyx8pcJnIimfpLYO46tolhNR3uZlzyLwAOyhCc PtHRXJFi/B+WRZFrgzJC1pkpfkCE/e919G6wQUNMlGbZxwil53Zm9sNSXN2T3kml671y iFJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=x/UA8N9071Hs67JB/CtCLOKYsRujWaxB61T4BkLclrk=; b=MkD3cJoa2FZpNsTUOEMD+y3Rask1MeyPPfaftftd9O6tBM3uVcYhA/ZlzXXvd0Som/ JO3JVii9N0lpl12AIglZgwcFtPBLRgl/VHX8T/sWYmjGagfElFjymUSEZoehGjFVUZ7O g0EhMByl40CNuEMSyK/merJHOGSXxnB/j4XzirhFLy2W7lHtuZsdxIvtNhdjfC2sNtqi fekWwbo5i4vufYqaV1+MhrKzdcJMe3ozE2V4/0XuuGTysql5ZIcjcH9cwYnGkfF9i+CY 4U3j5qUGIcc5RDoeYTOlcq2KutGhPONEC2X/D7+wPXxLrTwqZ4mtD3G/yBM+fvBPPMjF o9qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Uj//MN/e"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i26si5484053edy.197.2019.11.15.01.52.57; Fri, 15 Nov 2019 01:53:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Uj//MN/e"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727461AbfKOJue (ORCPT + 99 others); Fri, 15 Nov 2019 04:50:34 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:37340 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727374AbfKOJu2 (ORCPT ); Fri, 15 Nov 2019 04:50:28 -0500 Received: by mail-lj1-f193.google.com with SMTP id d5so10008786ljl.4 for ; Fri, 15 Nov 2019 01:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x/UA8N9071Hs67JB/CtCLOKYsRujWaxB61T4BkLclrk=; b=Uj//MN/eYpagIL5SFVK5o9mqojQITuF2XVCgryREyFOYqXwn9xWNIEKr/hnSu/yd37 OgcpwNqi83ryL9yGP1i3iNYM1NbRKkpytuLcvx7ux/H500d7XGmBTA1gGyjzvIoV1iEw ld7CduY+HoP5HPEWtCzcfMm9I2Dm+Qz4o73G7hmWuJKiE/659BHe9isr8jEu6zfrXY5w p6E8t5bh/a39/Z0Xs8X8yXae3wjaBpHdwtcjDJIrI75l11sES3dl5SnTE4LguB/l+0rp l/TlA8QLOU8hAcIlE+mlbdA00awq8mAiygKQOZVYY63BinchNpYcFAYnxZkBzVC+ig3U 4gDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x/UA8N9071Hs67JB/CtCLOKYsRujWaxB61T4BkLclrk=; b=HmVh4mEd/FqEVbC0YDQWtnKWbfBw3/lpfbZPz3/QYuiJCoSuAI4/Vk2YnygkCQA5M6 47gBga2UYwbr1xDygs2/Qz6Tmg0otFe0awd+ocxGMk7PpepM2ZfwHB0ej2wsSjPt7UDP W4UjmhGHEa9DA4bghI7BAjo495DErxqP6CV7OuvwuyTghJuN+JaoaLM8MWjmkw7mQQej NOMLLkTnxz2hlN8mas2Bdj1tqF6lvHFHGy+b0Kq3ZjBkaYnnhi41Lf+sja9+HnQ7AqIW Xo2QsZOZjCr74rY31xJbdwRr6Gos+g3bu6EiXZN1P5dh1XcNcH+tfQhibtdfSH9OnhrA B7qA== X-Gm-Message-State: APjAAAX48lPGYnjo0f5XcQ3rIlcDDZL/BZEonKoil4u8uy3We8uGxpIn c8ltxbagLt07zqX3BH5uNW86+/fNVyB1GoDKUhelvg== X-Received: by 2002:a2e:161b:: with SMTP id w27mr10500539ljd.183.1573811425820; Fri, 15 Nov 2019 01:50:25 -0800 (PST) MIME-Version: 1.0 References: <20191115062454.7025-1-hslester96@gmail.com> In-Reply-To: <20191115062454.7025-1-hslester96@gmail.com> From: Linus Walleij Date: Fri, 15 Nov 2019 10:50:14 +0100 Message-ID: Subject: Re: [PATCH] net: gemini: add missed free_netdev To: Chuhong Yuan Cc: Hans Ulli Kroll , "David S . Miller" , Linux ARM , netdev , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 15, 2019 at 7:25 AM Chuhong Yuan wrote: > This driver forgets to free allocated netdev in remove like > what is done in probe failure. > Add the free to fix it. > > Signed-off-by: Chuhong Yuan Looks correct! Reviewed-by: Linus Walleij Yours, Linus Walleij