Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4278084ybc; Fri, 15 Nov 2019 01:56:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwdTG0yk/gP4tJZNwU5DZKxLO4xkES98Xq/J764MFiKLeP59wwHD7kXnZmsd/8KwyH60MzW X-Received: by 2002:a17:906:69d2:: with SMTP id g18mr12383950ejs.153.1573811809859; Fri, 15 Nov 2019 01:56:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573811809; cv=none; d=google.com; s=arc-20160816; b=Iw+/XlavmtMNYc/OBaFtWJ8yFq34URWcXQJP/gt9LyCYUTUpFboxw2qjWpa0eomtoS mHbLg14RvOjmg79tON+teeRaS2U4ZEX3+/3VepOvZQVwo0tpP0cp9tRqyYKfZTKNOZJk wQ+WG9VwL0w4cSVzso64BNXQrAfL5BF+v1pZnoCGP+/5rLg5FWpiW7jctkUYoiL6BRzD ezA4DsLfkmpXVkHLtxAS+20Z6QtjrWfmk/5GHlJy0xyX+d8zwLX66R3ewPyNTT1R9Xls LcYeZmYek0SajDu7SUj7tjWtRazoZf7yLEv0n+FPXMLwUUYPGroEfqbhg5Yq5uQnELAN jlzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=KcNh6X0l2zRLPfGoUE/msaM7OeDRiyK7OF3strBs+WQ=; b=Qr2RcuA5fslJr1bE4EPK+dmSxHCybxWYvDnAk78imYRTT1kj9R871MoJLy5RVlYy8h cW9nRtYTIBrwZTa1bd6fuBF/DpaDx06ubR7RPvsEw4BbSVjNDvBUiBGG6np5EtUZwAB3 5mpRW/vTXuXWhxmzbQiFrArGMKkQcjNobvwhUxVyIBX+8mPhRyDN81UXbDGsi0+x2irm j42vSi5eZEDGmQs/puMqiQvQJGxJFYS8bL/CioALPJ0PwcBeZ+LngPPsFdwKMyhY8FyD Xsm9+PwnnRFvS5KlvgqYTRr5MZuAjzpqjzJf4MihvogUljtK5IW08cI+gGdNlAQMird8 Fu4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i14si5730269edr.68.2019.11.15.01.56.24; Fri, 15 Nov 2019 01:56:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727372AbfKOJzU (ORCPT + 99 others); Fri, 15 Nov 2019 04:55:20 -0500 Received: from foss.arm.com ([217.140.110.172]:56030 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfKOJzU (ORCPT ); Fri, 15 Nov 2019 04:55:20 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87A93328; Fri, 15 Nov 2019 01:55:19 -0800 (PST) Received: from [10.0.2.15] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CF503F534; Fri, 15 Nov 2019 01:55:18 -0800 (PST) Subject: Re: [PATCH] sched/uclamp: Fix overzealous type replacement To: Vincent Guittot Cc: linux-kernel , Ingo Molnar , Peter Zijlstra , Dietmar Eggemann , Tejun Heo , Patrick Bellasi , Suren Baghdasaryan , Quentin Perret References: <20191113165334.14291-1-valentin.schneider@arm.com> From: Valentin Schneider Message-ID: Date: Fri, 15 Nov 2019 09:55:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/11/2019 08:12, Vincent Guittot wrote: > > And static inline enum uclamp_id uclamp_none(enum uclamp_id clamp_id) ? > > Should it be fixed as well as it can return SCHED_CAPACITY_SCALE ? > Right, thanks for staring at this. I'll go double check the diff and fix up any strays.