Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] arm64: export __hyp_stub_vectors
To:     Peng Fan <peng.fan@nxp.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>
Cc:     "allison@lohutok.net" <allison@lohutok.net>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ralf.ramsauer@oth-regensburg.de" <ralf.ramsauer@oth-regensburg.de>,
        Alice Guo <alice.guo@nxp.com>, dl-linux-imx <linux-imx@nxp.com>
References: <1573810972-2159-1-git-send-email-peng.fan@nxp.com>
 <1573810972-2159-2-git-send-email-peng.fan@nxp.com>
From:   Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <3aeabfb9-0680-08f6-49bc-38930c7a23df@siemens.com>
Date:   Fri, 15 Nov 2019 10:58:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.1
MIME-Version: 1.0
In-Reply-To: <1573810972-2159-2-git-send-email-peng.fan@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 15.11.19 10:45, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> External hypervisors, like Jailhouse, need this address when they are
> deactivated, in order to restore original state.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>   arch/arm64/include/asm/virt.h | 2 ++
>   arch/arm64/kernel/hyp-stub.S  | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/virt.h b/arch/arm64/include/asm/virt.h
> index 0958ed6191aa..b1b48353e3b3 100644
> --- a/arch/arm64/include/asm/virt.h
> +++ b/arch/arm64/include/asm/virt.h
> @@ -62,6 +62,8 @@
>    */
>   extern u32 __boot_cpu_mode[2];
>   
> +extern char __hyp_stub_vectors[];
> +
>   void __hyp_set_vectors(phys_addr_t phys_vector_base);
>   void __hyp_reset_vectors(void);
>   
> diff --git a/arch/arm64/kernel/hyp-stub.S b/arch/arm64/kernel/hyp-stub.S
> index f17af9a39562..22b728fb14bd 100644
> --- a/arch/arm64/kernel/hyp-stub.S
> +++ b/arch/arm64/kernel/hyp-stub.S
> @@ -38,6 +38,7 @@ ENTRY(__hyp_stub_vectors)
>   	ventry	el1_fiq_invalid			// FIQ 32-bit EL1
>   	ventry	el1_error_invalid		// Error 32-bit EL1
>   ENDPROC(__hyp_stub_vectors)
> +EXPORT_SYMBOL(__hyp_stub_vectors);
>   
>   	.align 11
>   
> 

While I would not dislike to have patch-free access in Jailhouse, I'm 
not sure if an out-of-tree use case justifies this an export.

Also, this lacks the arm equivalent to be complete.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux