Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 15 Nov 2019 11:28:33 +0100
From:   Jessica Yu <jeyu@kernel.org>
To:     Konstantin Khorenko <khorenko@virtuozzo.com>
Cc:     Prarit Bhargava <prarit@redhat.com>,
        Barret Rhoden <brho@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        linux-kernel@vger.kernel.org, David Arcari <darcari@redhat.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH 1/1] kernel/module.c: wakeup processes in module_wq on
 module unload
Message-ID: <20191115102832.GA1647@linux-8ccs>
References: <20191113092950.15556-1-khorenko@virtuozzo.com>
 <20191113092950.15556-2-khorenko@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20191113092950.15556-2-khorenko@virtuozzo.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+++ Konstantin Khorenko [13/11/19 12:29 +0300]:
>Fix the race between load and unload a kernel module.
>
>sys_delete_module()
> try_stop_module()
>  mod->state = _GOING
>					add_unformed_module()
>					 old = find_module_all()
>					 (old->state == _GOING =>
>					  wait_event_interruptible())
>
>					 During pre-condition
>					 finished_loading() rets 0
>					 schedule()
>					 (never gets waken up later)
> free_module()
>  mod->state = _UNFORMED
>   list_del_rcu(&mod->list)
>   (dels mod from "modules" list)
>
>return
>
>The race above leads to modprobe hanging forever on loading
>a module.
>
>Error paths on loading module call wake_up_all(&module_wq) after
>freeing module, so let's do the same on straight module unload.
>
>Fixes: 6e6de3dee51a ("kernel/module.c: Only return -EEXIST
>for modules that have finished loading")
>
>Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>

Thanks Konstantin for catching this. I've applied this to
modules-next.

Jessica