Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   jouni.hogander@unikie.com (Jouni =?utf-8?Q?H=C3=B6gander?=)
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH] drivers/base: Fix memory leak in error paths
References: <20191114121840.5585-1-jouni.hogander@unikie.com>
        <20191115032603.GG793701@kroah.com> <878soha7tc.fsf@unikie.com>
        <20191115082022.GB55909@kroah.com> <8736epa202.fsf@unikie.com>
        <20191115101902.GB337025@kroah.com>
Date:   Fri, 15 Nov 2019 12:32:31 +0200
In-Reply-To: <20191115101902.GB337025@kroah.com> (Greg Kroah-Hartman's message
        of "Fri, 15 Nov 2019 18:19:02 +0800")
Message-ID: <87y2wh8m68.fsf@unikie.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

>>=20
>> Ok, did some more debugging on
>> this. net/core/net-sysfs.c:netdev_register_kobject is doing
>> device_initialize(dev). This is in
>> drivers/base/core.c:device_initialize:
>>=20
>>  * NOTE: Use put_device() to give up your reference instead of freeing
>>  * @dev directly once you have called this function.
>>=20
>> My understanding is that remaining reference on error path is taken by
>> device_initialize and as instructed in the note above it should be given
>> up using put_device?
>
> Yes, that is correct.
>
>> Tested this and it's fixing the memory leak I found in my Syzkaller
>> exercise. Addition to that it seems to be fixing also this one:
>>=20
>> https://syzkaller.appspot.com/bug?id=3Df5f4af9fb9ffb3112ad6e30f717f769de=
cdccdfc
>
> Great!  Care to submit a patch for this?

I will submit another patch and Cc you there. This patch should be ignored.

BR,

Jouni H=C3=B6gander