Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 15 Nov 2019 13:20:28 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     You-Sheng Yang <vicamo.yang@canonical.com>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Hui Wang <hui.wang@canonical.com>,
        HungNien Chen <hn.chen@weidahitech.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: remove orphaned member sleep_delay
In-Reply-To: <20191115053646.3107290-1-vicamo.yang@canonical.com>
Message-ID: <nycvar.YFH.7.76.1911151320220.1799@cbobk.fhfr.pm>
References: <20191115053646.3107290-1-vicamo.yang@canonical.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 15 Nov 2019, You-Sheng Yang wrote:

> This was introduced in commit 00b790ea545b ("HID: i2c-hid: Add a small
> delay after sleep command for Raydium touchpanel") which has been
> effectively reverted by commit 67b18dfb8cfc ("HID: i2c-hid: Remove
> runtime power management").
> 
> Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
> ---
>  drivers/hid/i2c-hid/i2c-hid-core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 04c088131e04..adfe344bc786 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -157,8 +157,6 @@ struct i2c_hid {
>  
>  	bool			irq_wake_enabled;
>  	struct mutex		reset_lock;
> -
> -	unsigned long		sleep_delay;
>  };

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs